Skip to content

fix: stop retrying reviewer self-approval failures#230

Merged
mrcfps merged 1 commit intomainfrom
looper/224-reviewer-clean-approve-reviews-44c302100b2f84ce
May 6, 2026
Merged

fix: stop retrying reviewer self-approval failures#230
mrcfps merged 1 commit intomainfrom
looper/224-reviewer-clean-approve-reviews-44c302100b2f84ce

Conversation

@mrcfps
Copy link
Copy Markdown
Contributor

@mrcfps mrcfps commented May 6, 2026

Summary

  • Classify GitHub self-approval review failures as non-retryable reviewer failures.
  • Add regression coverage so a failed own-PR APPROVE attempt leaves the queue failed instead of requeued.

Validation

  • go test ./internal/reviewer ./internal/cliapp ./internal/infra/github
  • go vet ./...
  • go build ./...
  • go test ./...

Closes #224

Generated by Looper 0.6.0 · runner=worker · agent=codex

Classify GitHub self-approval review errors as deterministic reviewer failures so older APPROVE attempts do not requeue forever.

Generated-By: looper 0.6.0 (runner=worker, agent=codex)
@mrcfps mrcfps merged commit 8b5a292 into main May 6, 2026
1 check passed
@mrcfps mrcfps deleted the looper/224-reviewer-clean-approve-reviews-44c302100b2f84ce branch May 6, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reviewer: clean APPROVE reviews against own PRs fail with GitHub 422 and loop forever

1 participant