Skip to content

Update lodash reference in vite optimizeDeps demo configs #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Chriztiaan merged 7 commits into from
Apr 29, 2024
Merged

Update lodash reference in vite optimizeDeps demo configs #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0856c02
Update lodash reference in vite optimizeDeps config
aguynamedloren Apr 16, 2024
a9d16d4
Merge branch 'main' into main
Chriztiaan Apr 16, 2024
8f35803
fix: using nested include entries for demo apps
Apr 16, 2024
efbfee2
chore: added changeset entries
Apr 16, 2024
ed283ac
Merge branch 'main' into main
Chriztiaan Apr 17, 2024
3f58642
Merge branch 'main' into main
Chriztiaan Apr 25, 2024
48ffeb7
Merge branch 'main' into main
Chriztiaan Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/clever-kiwis-lay.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
"example-vite": patch
"@journeyapps/powersync-react-supabase-todolist": patch
"@journeyapps/powersync-yjs-text-collab-demo": patch
"@journeyapps/powersync-vue": patch
---

Updated Vite Demo apps' `include` entries to use nested dependency syntax, fixes issue with CJS nested dependencies.
8 changes: 7 additions & 1 deletion demos/example-vite/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,13 @@ export default defineConfig({
// Don't optimize these packages as they contain web workers and WASM files.
// https://github.com/vitejs/vite/issues/11672#issuecomment-1415820673
exclude: ['@journeyapps/wa-sqlite', '@powersync/web'],
include: ['object-hash', 'uuid', 'event-iterator', 'js-logger', 'lodash', 'can-ndjson-stream']
include: [
'@powersync/web > uuid',
'@powersync/web > event-iterator',
'@powersync/web > js-logger',
'@powersync/web > lodash/throttle',
'@powersync/web > can-ndjson-stream'
]
},
plugins: [wasm(), topLevelAwait()],
worker: {
Expand Down
8 changes: 7 additions & 1 deletion demos/react-supabase-todolist/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,13 @@ export default defineConfig({
// Don't optimize these packages as they contain web workers and WASM files.
// https://github.com/vitejs/vite/issues/11672#issuecomment-1415820673
exclude: ['@journeyapps/wa-sqlite', '@powersync/web'],
include: ['object-hash', 'uuid', 'event-iterator', 'js-logger', 'lodash', 'can-ndjson-stream']
include: [
'@powersync/web > uuid',
'@powersync/web > event-iterator',
'@powersync/web > js-logger',
'@powersync/web > lodash/throttle',
'@powersync/web > can-ndjson-stream'
]
},
plugins: [
wasm(),
Expand Down
2 changes: 1 addition & 1 deletion demos/vue-supabase-todolist/vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export default defineConfig({
// https://github.com/vitejs/vite/issues/11672#issuecomment-1415820673
exclude: ['@journeyapps/wa-sqlite', '@powersync/web'],
include: [
'@powersync/common > uuid',
'@powersync/web > uuid',
'@powersync/web > event-iterator',
'@powersync/web > js-logger',
'@powersync/web > lodash/throttle',
Expand Down
8 changes: 7 additions & 1 deletion demos/yjs-react-supabase-text-collab/vite.config.mts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ export default defineConfig({
// Don't optimize these packages as they contain web workers and WASM files.
// https://github.com/vitejs/vite/issues/11672#issuecomment-1415820673
exclude: ['@journeyapps/wa-sqlite', '@powersync/web'],
include: ['object-hash', 'uuid', 'event-iterator', 'js-logger', 'lodash', 'can-ndjson-stream']
include: [
'@powersync/web > uuid',
'@powersync/web > event-iterator',
'@powersync/web > js-logger',
'@powersync/web > lodash/throttle',
'@powersync/web > can-ndjson-stream'
]
},
plugins: [
wasm(),
Expand Down