feat(reat): allow compilable query as hook argument #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
reviewed
Apr 30, 2024
Chriztiaan
reviewed
May 2, 2024
added 2 commits
May 2, 2024 10:50
added 2 commits
May 2, 2024 11:25
Chriztiaan
reviewed
May 2, 2024
|
|
||
| // The test returns unhandled errors when run with all the others. | ||
| // TODO: Fix the test so that there are no unhandled errors (this may be a vitest or @testing-library/react issue) | ||
| it.only('should show an error if parsing the query results in an error', async () => { |
Chriztiaan
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow compilable queries as hook arguments so that ORM's e.g. kysely queries can be used as arguments in place of string SQL statements
Work Done
How to Test
useQueryhook