Skip to content

Conversation

@DominicGBauer
Copy link
Contributor

@DominicGBauer DominicGBauer commented May 20, 2024

Description

Add "updateInternalDependents": "out-of-range" option to changeset config so that underlying dependencies (e.g. @powersync/react are only updated when @powersync/common is major version updated.

I have further changed the dependency range to be more specific by using >= 1.7.0 < 2.

This has been tested locally to verify that it works as expected.
Example: if you have

  "name": "@powersync/react",
  "version": "1.3.3",
"peerDependencies": {
    "@powersync/common": "workspace:>= 1.7.0 < 2"
  },

And you do a minor or patch version update to @powersync/common the package that has the above peerDependencies will not require a version bump. However if you do a major version bump to @powersync/common then it will be changed to

  "name": "@powersync/react",
  "version": "2.0.0",
"peerDependencies": {
    "@powersync/common": "workspace:>=2.0.0"
  },

and require a major version bump of the dependent package.

@DominicGBauer DominicGBauer self-assigned this May 20, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DominicGBauer DominicGBauer merged commit b5429c0 into main May 20, 2024
@DominicGBauer DominicGBauer deleted the chore/add-to-changeset-config branch May 20, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants