fix(web): multiple tabs not working #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue introduced by #178 where multiple tabs were not syncing correctly. This PR fixes this issue by setting
useWebWorkerto true by default for thesyncImplementationweb worker.The shared sync implementation (which resides inside a web worker) creates a WASQLite connection from a worker message port which is supplied to it. We need to specify
useWebWorkerwhen creating the WASQLite connection adapter to correctly use the supplied message port. This port should always be available to the shared sync implementation so that syncing can occur.Video
Screen.Recording.2024-05-28.at.16.36.00.mov