Fix web lock issues #226
Merged
Fix web lock issues #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1b52be The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
commented
Jul 16, 2024
| expect(rows.length).toEqual(1); | ||
| expect(rows[0].name).toEqual('John'); | ||
| expect(getAllSpy).toHaveBeenCalledTimes(1); | ||
| expect(getAllSpy).toHaveBeenCalledWith('SELECT * From users', []); |
Contributor
Author
There was a problem hiding this comment.
The watch from updateHasSynced (SELECT 1 FROM ps_buckets WHERE last_applied_op > 0 LIMIT 1) interfered with the toHaveBeenCalledTimes(1) test. The test worked previously, but the lock fix changed the timing of the call, which caused this test to break.
This now just tests that it has been called correctly once, and ignores any other calls.
stevensJourney
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASQLiteDBAdapterdid not correctly lock read statements (get,getAllandgetOptional). This meant these statements could be run in the middle of another transaction and return inconsistent results.This also changes the global lock in
open-db.tsto a local Mutex, since it is only relevant for that specific connection. This may give a minor performance improvement - navigator.locks can be slow when tabs/workers are busy.