Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes a regression from #211.
The PR above introduced the ability to directly construct a
PowerSyncDatabase. TheAbstractPowerSyncDatabaseaccepts either an instance ofDBAdapter, a SQLite open factory which will be used to open aDBAdapteror options to be used with a default SQLite open factory.If options are provided the
AbstractPowerSyncDatabaseconstructor will call the abstractopenDBAdaptermethod withSQLOpenOptions.Web implementations require additional
flagswhen opening SQLite connections. The implementation previously assumed theresolvedFlagswere available in theopenAdaptermethod. This is not the case since thesuper()method is called before the resolved flags are assigned. This would cause the supplied flags to be ignored when creating DB connections. In practise this disregarded theuseWebWorkerflag.This PR updates the internal and
protectedopenAdaptermethod to have access to all theoptionsprovided to thePowerSyncDatabaseconstructor.Unit tests have been added to ensure workers are correctly used given the relevant
flags.