Skip to content

Conversation

@guillempuche
Copy link
Contributor

@guillempuche guillempuche commented Aug 13, 2024

Prevent this issue:

Uncaught SyntaxError: The requested module 'http://localhost:3000/@fs/.../<repo>/node_modules/js-logger/src/logger.js?v=eb4a8b9e' doesn't provide an export named: 'default'

Discussion started on Discord https://discord.com/channels/1138230179878154300/1272981660589363293

Prevent this issue:
```
Uncaught SyntaxError: The requested module 'http://localhost:3000/@fs/.../<repo>/node_modules/js-logger/src/logger.js?v=eb4a8b9e' doesn't provide an export named: 'default'
```
@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2024

⚠️ No Changeset found

Latest commit: 1adcab0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@guillempuche guillempuche changed the title Update vite.config.mts to warn about js-logger Update Supabase example to warn about js-logger when running Vite Aug 13, 2024
@guillempuche guillempuche changed the title Update Supabase example to warn about js-logger when running Vite Update Supabase demo to warn about js-logger when running Vite Aug 13, 2024
@MrLightful
Copy link
Contributor

MrLightful commented Aug 19, 2024

I had to include js-logger even having it installed in package.json. Can you please double check this?

@guillempuche
Copy link
Contributor Author

In my case, I didn't install it.

@MrLightful
Copy link
Contributor

MrLightful commented Aug 19, 2024

In my case, I didn't install it.

Yeah well I mean phrasing Only when 'js-logger' isn't installed in package.json suggests that you don't need it when js-logger installed. But it seems that it's needed even when it's installed. So maybe just recommend to always include it? Or when you install it, it's not breaking without include?

@guillempuche
Copy link
Contributor Author

guillempuche commented Aug 20, 2024

What about now?

@Chriztiaan
Copy link
Contributor

Chriztiaan commented Aug 21, 2024

So turns out you need to install js-logger and configure/apply it, alternatively you can have the include rule. I think we should just add the include rule everywhere for the moment. @guillempuche would you mind applying it to all the vite projects when you have a moment - since you already have this PR going :) ?

@guillempuche
Copy link
Contributor Author

@Chriztiaan, done.

@Chriztiaan
Copy link
Contributor

Looks like there is work being done on this here to resolve the underlying exclude issue.

@Chriztiaan Chriztiaan removed the request for review from stevensJourney August 26, 2024 07:13
@Chriztiaan Chriztiaan merged commit 3d75577 into powersync-ja:main Aug 26, 2024
@guillempuche guillempuche deleted the patch-1 branch August 26, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants