-
Notifications
You must be signed in to change notification settings - Fork 61
Web tests with Vitest #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevensJourney
commented
Feb 22, 2024
rkistner
reviewed
Feb 23, 2024
packages/powersync-sdk-common/src/client/AbstractPowerSyncDatabase.ts
Outdated
Show resolved
Hide resolved
rkistner
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds automated tests for the Web SDK using Vitest and WebdriverIO.
Tests are performed in a browser environment due to the requirements for
SharedWorkerNavigatorlocks and WASM loading.This PR uses an interesting TypeScript and Vite config to allow resolving web worker URIs to be compatible with Webpack and Vite. In the web SDK package: Vite will only resolve web worker URIs correctly if the file path ends with
.tswhile the URI should use.jsin published packages (not using the source files directly).The method used here is to use the
@journeyapps/powersync-sdk-webpackage path alias as an import source for the**/*.test.tsfiles. This alias is then resolved in the Vite bundling step to the Javascriptdistversion of thesrc.