Skip to content

Conversation

@rkistner
Copy link
Contributor

@rkistner rkistner commented Nov 6, 2025

Fix build regression from #753.

This caused prod builds (package releases) to hang on the build step. Weirdly, it doesn't happen when running pnpm build:prod directly in the attachments package, but does happen when running the global pnpm build:packages:prod.

@rkistner rkistner requested a review from simolus3 November 6, 2025 12:44
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 471ec03

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@simolus3 simolus3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch, sorry for that and thanks for adding the :prod step to catch this in the future 👍

@rkistner rkistner merged commit 66f1076 into main Nov 6, 2025
9 of 19 checks passed
@rkistner rkistner deleted the fix-attachments-build branch November 6, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants