Skip to content

feat: add total buckets tracking#926

Merged
joshuabrink merged 7 commits intomainfrom
feat/total-buckets-preview
Apr 13, 2026
Merged

feat: add total buckets tracking#926
joshuabrink merged 7 commits intomainfrom
feat/total-buckets-preview

Conversation

@joshuabrink
Copy link
Copy Markdown
Contributor

Enhances the Sync Diagnostics page by making the server-side parameter query result limit more visible to users and providing clearer warnings as the bucket count approaches this limit.

@joshuabrink joshuabrink requested a review from bean1352 April 13, 2026 09:51
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

🦋 Changeset detected

Latest commit: 5bb7870

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@powersync/diagnostics-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

@rkistner rkistner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's great to track & report this, but should be clear on the wording.

Note that there are actually two separate limits, both with a default of 1000, and both reported with code PSYNC_S2305:

  1. "Too many buckets". This is what the PR here measures.
  2. "Too many parameter query results".

These are often the same, but is different in some important cases:

  1. If the parameter query or sync stream subquery has duplicate results, those are counted individually for "parameter query results", but de-duplicated in the bucket count.
  2. Queries that don't result in partitioning don't count towards "parameter query results", but do count 1 towards the number of buckets.

Another point is that the limit of 1000 is the default. While it's not common to change this, the text here shouldn't present that as always the case.

@joshuabrink joshuabrink force-pushed the feat/total-buckets-preview branch from c59ba20 to 700175b Compare April 13, 2026 11:13
Comment thread tools/diagnostics-app/src/app/views/sync-diagnostics.tsx Outdated
bean1352
bean1352 previously approved these changes Apr 13, 2026
@joshuabrink joshuabrink marked this pull request as ready for review April 13, 2026 13:09
Comment thread tools/diagnostics-app/src/app/views/sync-diagnostics.tsx Outdated
@joshuabrink joshuabrink merged commit d8b2799 into main Apr 13, 2026
10 of 11 checks passed
@joshuabrink joshuabrink deleted the feat/total-buckets-preview branch April 13, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants