Fix Apple frameworks to contain version numbers #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobiebotha
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #301, we've moved the top-level
allprojectsblock responsible for setting the package version into the sonatype publishing plugin.Since the
:internal:PowerSyncKotlinproject used by the Swift SDK doesn't apply the Sonatype plugin, it doesn't have a version number anymore. This causes AppStore builds of apps using that framework to get rejected.We shouldn't apply the Sonatype plugin to that project because it's not uploaded to Maven Central, but we can introduce a plugin for just that functionality. I've done that in this PR, and also made the Sonatype plugin apply the version plugin.
I've tested that: