Correct Github links#4
Merged
Merged
Conversation
kobiebotha
approved these changes
May 31, 2024
Sleepful
added a commit
to Sleepful/powersync-service
that referenced
this pull request
May 21, 2026
Two serialization fidelity tests verifying loadBucketDataDocument() propagates doc.target_op to individual yielded ops. These should fail until the implementation fix is applied. Review feedback: rkistner on PR powersync-ja#617, comment powersync-ja#4.
Sleepful
added a commit
to Sleepful/powersync-service
that referenced
this pull request
May 21, 2026
Change from hardcoded null to doc.target_op ?? null so downstream consumers receive the document-level target_op value. Makes the target_op propagation tests pass. Review feedback: rkistner on PR powersync-ja#617, comment powersync-ja#4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct, and full, Github links for Docker Hub.