Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/popular-rivers-smell.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-image': patch
---

Fix websockets not being closed on authentication error
17 changes: 9 additions & 8 deletions service/src/runners/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,28 +85,29 @@ export async function startServer(runnerConfig: core.utils.RunnerConfig) {
const { token } = core.routes.RSocketContextMeta.decode(deserialize(data) as any);

if (!token) {
throw new errors.ValidationError('No token provided in context');
throw new errors.AuthorizationError('No token provided');
}

try {
const extracted_token = core.routes.auth.getTokenFromHeader(token);
if (extracted_token != null) {
const { context, errors } = await core.routes.auth.generateContext(system, extracted_token);
const { context, errors: token_errors } = await core.routes.auth.generateContext(system, extracted_token);
if (context?.token_payload == null) {
throw new errors.AuthorizationError(token_errors ?? 'Authentication required');
}
return {
token,
...context,
token_errors: errors,
token_errors: token_errors,
system
};
} else {
throw new errors.AuthorizationError('No token provided');
}
} catch (ex) {
logger.error(ex);
throw ex;
}

return {
token,
system
};
},
endpoints: [core.routes.endpoints.syncStreamReactive(SocketRouter)],
metaDecoder: async (meta: Buffer) => {
Expand Down