Skip to content

Comments

SQL Server: enable connections to SQL Server 2019#491

Merged
kobiebotha merged 5 commits intomainfrom
feat/sql-server-2019
Feb 10, 2026
Merged

SQL Server: enable connections to SQL Server 2019#491
kobiebotha merged 5 commits intomainfrom
feat/sql-server-2019

Conversation

@kobiebotha
Copy link
Contributor

Background
SQL Server 2019 supports CDC tables, so it should work, it was just a matter of not being tested.

In this PR

  • After bumping the supported minimum version, initial testing showed that SQL Server 2019 LSNs could contain lowercase hex characters e.g. 0000002e:00006a18:0001
  • Official MS docs show that other versions of SQL Server might return LSNs in lowercase format too, indicating that textual LSN case is not semantically meaningful (underlying value is binary). So we probably want to support this format anyway, regardless of the server version.
  • The method LSN.fromString() was updated to support either lowercase or upper case LSNs, and always uppercases when returning
    • A test was added for this

Testing performed*

  1. Manual testing demonstrated nominal behavior:
Screen.Recording.2026-02-07.at.8.59.22.PM.mov
  1. service-module-mssql unit tests pass (both bucket storage adapters)
image

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

🦋 Changeset detected

Latest commit: e09e413

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@powersync/service-module-mssql Minor
@powersync/service-image Patch
@powersync/service-core Patch
@powersync/service-schema Patch
@powersync/service-core-tests Patch
@powersync/service-module-core Patch
@powersync/service-module-mongodb-storage Patch
@powersync/service-module-mongodb Patch
@powersync/service-module-mysql Patch
@powersync/service-module-postgres-storage Patch
@powersync/service-module-postgres Patch
test-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rentacookie
Copy link
Contributor

Great that is good news that things still work on the older version. We should then also permanently enable the unit tests for 2019 in our test pipeline. Can add 2019 into the testing matrix here.

Then we also just need a changeset.

@kobiebotha kobiebotha marked this pull request as ready for review February 9, 2026 22:58
@kobiebotha kobiebotha merged commit e11289d into main Feb 10, 2026
26 checks passed
@kobiebotha kobiebotha deleted the feat/sql-server-2019 branch February 10, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants