SQL Server: enable connections to SQL Server 2019#491
Merged
kobiebotha merged 5 commits intomainfrom Feb 10, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: e09e413 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Great that is good news that things still work on the older version. We should then also permanently enable the unit tests for 2019 in our test pipeline. Can add 2019 into the testing matrix here. Then we also just need a changeset. |
GENERATE_SERIES was introduced in SQL Server 2022
Rentacookie
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
SQL Server 2019 supports CDC tables, so it should work, it was just a matter of not being tested.
In this PR
0000002e:00006a18:0001LSN.fromString()was updated to support either lowercase or upper case LSNs, and always uppercases when returningTesting performed*
Screen.Recording.2026-02-07.at.8.59.22.PM.mov
service-module-mssqlunit tests pass (both bucket storage adapters)