Propagate bucket and parameter index source#545
Merged
Conversation
🦋 Changeset detectedLatest commit: 914a9f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
simolus3
previously approved these changes
Mar 5, 2026
7d2264f to
914a9f5
Compare
simolus3
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #543. Where that PR added the bucked and parameter index sources to the sync rule APIs to make it available, this PR propagates it to the storage APIs - specifically to the
getBucketDataBatchandgetChecksumsAPIs. This allows the implementations to use the source to partition the storage.While the core changes are fairly small, this does have a significant impact on tests, which now need the source in many more places. This changes the tests to lookup the source from the original bucket name, and then translates the bucket name using the hydrated state. While this is more work, it does also remove a hack previously used to convert bucket names into versioned ones in tests where relevant.
Similar to #543, this should be an internal refactoring only - no change visible to users.