Skip to content

Propagate bucket and parameter index source#545

Merged
rkistner merged 6 commits intomainfrom
propagate-source
Mar 5, 2026
Merged

Propagate bucket and parameter index source#545
rkistner merged 6 commits intomainfrom
propagate-source

Conversation

@rkistner
Copy link
Contributor

@rkistner rkistner commented Mar 4, 2026

Builds on #543. Where that PR added the bucked and parameter index sources to the sync rule APIs to make it available, this PR propagates it to the storage APIs - specifically to the getBucketDataBatch and getChecksums APIs. This allows the implementations to use the source to partition the storage.

While the core changes are fairly small, this does have a significant impact on tests, which now need the source in many more places. This changes the tests to lookup the source from the original bucket name, and then translates the bucket name using the hydrated state. While this is more work, it does also remove a hack previously used to convert bucket names into versioned ones in tests where relevant.

Similar to #543, this should be an internal refactoring only - no change visible to users.

@rkistner rkistner requested a review from simolus3 March 4, 2026 16:14
@changeset-bot
Copy link

changeset-bot bot commented Mar 4, 2026

🦋 Changeset detected

Latest commit: 914a9f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@powersync/service-module-postgres-storage Minor
@powersync/service-module-mongodb-storage Minor
@powersync/service-core-tests Minor
@powersync/service-module-postgres Minor
@powersync/service-module-mongodb Minor
@powersync/service-core Minor
@powersync/service-module-mssql Minor
@powersync/service-module-mysql Minor
@powersync/service-sync-rules Minor
@powersync/service-schema Minor
@powersync/service-image Minor
@powersync/service-module-core Patch
test-client Patch
@powersync/service-jpgwire Patch
@powersync/lib-services-framework Patch
@powersync/lib-service-postgres Patch
@powersync/service-rsocket-router Patch
@powersync/lib-service-mongodb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rkistner rkistner marked this pull request as ready for review March 4, 2026 16:16
simolus3
simolus3 previously approved these changes Mar 5, 2026
Base automatically changed from track-source to main March 5, 2026 10:16
@rkistner rkistner dismissed simolus3’s stale review March 5, 2026 10:16

The base branch was changed.

@rkistner rkistner merged commit c15efc7 into main Mar 5, 2026
31 checks passed
@rkistner rkistner deleted the propagate-source branch March 5, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants