[MongoDB] Fix checkpoint stalling#659
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3b3d65c The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rkistner
commented
Jun 3, 2026
stevensJourney
approved these changes
Jun 4, 2026
Collaborator
stevensJourney
left a comment
There was a problem hiding this comment.
The changes here look good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue surfaced in #573 (v1.20.3). Even though the issue was not directly caused by that PR, it removed a fallback path that would have bypassed the issue.
What happens:
createCheckpoint()is called.lsn >= waitForCheckpointLsncondition to not be hit when the change stream event is received.Issue symptoms
The issue shows up as replication lag building up, without an actual backlog of data to process. Specifically:
processingtime.The fix
A good long term fix would be to use a sentinel-based approach, rather than relying on MongoDB clusterTime behavior and potentially making bad assumptions around that - see #605. However, that's a big and risky change.
The fix here is to bypass the internal driver's retry mechanism for writes. By adding our own retry logic, the retry will actually produce a new write with a new change stream event, which avoids this issue.
AI usage
Used Codex gpt-5.5 to debug the issue and assist in writing a test for reproducing it.
The fix here was implemented manually.