Skip to content

fix: make benchmark alerts advisory and benchmark realistic list paths#106

Merged
poyrazK merged 1 commit intofeature/multi-tenancy-rbac-refactorfrom
chore/benchmark-rbac-listing-fixes
Apr 4, 2026
Merged

fix: make benchmark alerts advisory and benchmark realistic list paths#106
poyrazK merged 1 commit intofeature/multi-tenancy-rbac-refactorfrom
chore/benchmark-rbac-listing-fixes

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 4, 2026

Summary

  • stop failing pull requests on benchmark alerts while keeping benchmark reporting enabled
  • replace the empty noop list benchmarks with tenant-aware list benchmarks over non-empty datasets
  • make the fake benchmark repositories copy result slices so benchmark costs scale with list size instead of interface wrapper overhead

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4035daa3-b5fb-4f3f-88f8-964d363a50d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/benchmark-rbac-listing-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@poyrazK poyrazK merged commit 49949b9 into feature/multi-tenancy-rbac-refactor Apr 4, 2026
1 check passed
@poyrazK poyrazK deleted the chore/benchmark-rbac-listing-fixes branch April 12, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant