chore: resolve advanced lint issues and improve test coverage to 64.8% by poyrazK · Pull Request #65 · poyrazK/thecloud

poyrazK · 2026-02-21T16:53:12Z

Overview

This PR resolves remaining advanced linter issues (specifically forcetypeassert) and significantly improves codebase test coverage, reaching 64.8%.

Changes

Lint and Error Handling

Resolved all forcetypeassert violations by using safe comma-ok type assertions.
Standardized error handling by aliasing standard library errors as stdlib_errors and using errors.Is/errors.As.
Improved error wrapping across repository adapters (LVM, Libvirt).

Test Coverage Improvements

Added or expanded unit tests for the following components:

Services: Auth lockout logic, API key caching, Gateway route management, Dashboard stats, and more.
Workers: Accounting, Metrics Collector, and Cluster Reconciler loops.
Repositories: Comprehensive coverage for Postgres repositories (Cluster, Cron, Autoscaling) and the Libvirt adapter.
Adapters: Firecracker noop adapter now has 100% coverage.

Architecture and Main Entry Point

Restructured cmd/api/main.go into granular helper functions (run, initInfrastructure, initBackends) for better maintainability and testability.
Updated worker initialization to be more robust and configurable.
Resolved accidental code duplication in the main API entry point.

Verification

make test passes all unit tests.
Statement coverage verified at 64.8%.

…lb, and iam repos

…, and lb repos

Copilot

Pull request overview

Copilot reviewed 247 out of 249 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…art 6

Copilot

Pull request overview

Copilot reviewed 250 out of 252 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T11:43:40Z

@@ -383,7 +383,6 @@ var sshCmd = &cobra.Command{
 		// This handles interactive terminal correctly.
 		env := os.Environ()
 		allArgs := append([]string{"ssh"}, sshArgs...)


This syscall.Exec call is likely to trigger gosec G204 (subprocess launched with variable / user-controlled args). The previous //nolint:gosec suppression was removed, but .golangci.yml does not exclude G204, so CI may fail. Add back an explicit suppression with a short justification, or refactor in a way that satisfies gosec (if possible).

Suggested change

allArgs := append([]string{"ssh"}, sshArgs...)

allArgs := append([]string{"ssh"}, sshArgs...)

//nolint:gosec // ssh is executed directly (no shell); user-controlled args are expected for interactive SSH

Copilot · 2026-02-24T11:43:40Z

 func setupSubnetServiceTest(t *testing.T) (*services.SubnetService, *postgres.SubnetRepository, *postgres.VpcRepository, context.Context) {
+	t.Helper()
+	t.Helper()
 	db := setupDB(t)


setupSubnetServiceTest calls t.Helper() twice; the second call is redundant. Removing the duplicate keeps the test helper consistent and avoids unnecessary lint noise.

…isfy thelper and testifylint

… on shared DB

Copilot

Pull request overview

Copilot reviewed 250 out of 252 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 251 out of 253 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ube lints

Copilot

Pull request overview

Copilot reviewed 241 out of 317 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T14:05:54Z

+	stdlib_errors "errors"
 	"time"



The import of stdlib_errors should be placed after standard library imports and before third-party imports, following the conventional Go import ordering.

Suggested change

stdlib_errors "errors"

"time"

"time"

stdlib_errors "errors"

Copilot · 2026-02-24T14:05:55Z


 func setupSubnetServiceTest(t *testing.T) (*services.SubnetService, *postgres.SubnetRepository, *postgres.VpcRepository, context.Context) {
+	t.Helper()
+	t.Helper()


Duplicate t.Helper() call should be removed. Only one call is needed.

Suggested change

t.Helper()

Copilot · 2026-02-24T14:05:55Z

+	t.Cleanup(func() {
+		db.Close()
+	})


The database cleanup is now registered but the old deferred cleanup pattern was likely present. Verify that there are no duplicate cleanup mechanisms that could cause issues.

Copilot · 2026-02-24T14:05:55Z

+		// Mask user existence for security, but return other errors
+		if errors.Is(err, errors.NotFound) {
+			return nil
+		}
+		return err


Returning different errors based on whether the user exists could allow user enumeration attacks. Consider always returning nil or a generic message for security, regardless of whether the user exists or not.

Suggested change

// Mask user existence for security, but return other errors

if errors.Is(err, errors.NotFound) {

return nil

}

return err

// Mask user existence for security while avoiding leaking internal errors.

if errors.Is(err, errors.NotFound) {

return nil

}

s.logger.Error("failed to get user by email for password reset", "email", email, "error", err)

return stdlib_errors.New("could not process password reset request")

Copilot

Pull request overview

Copilot reviewed 241 out of 318 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-24T14:15:40Z

@@ -3,10 +3,10 @@ package postgres

 import (
 	"context"


The import of stdlib_errors should be placed after the standard library import block and before third-party imports to maintain proper import grouping.

Suggested change

"context"

"context"

Copilot · 2026-02-24T14:15:40Z

+	t.Helper()
 	if testing.Short() {
 		t.Skip("Skipping integration test in short mode")
 	}


The t.Helper() call should be placed after the testing.Short() check to avoid unnecessary helper marking when the test is skipped.

Suggested change

t.Helper()

if testing.Short() {

t.Skip("Skipping integration test in short mode")

}

if testing.Short() {

t.Skip("Skipping integration test in short mode")

}

t.Helper()

Copilot · 2026-02-24T14:15:41Z

 		logger: logger,
 		ttl:    5 * time.Minute,
 	}
 }


Removed blank line between function definitions is inconsistent with Go formatting conventions. Consider restoring the blank line for better readability.

Suggested change

}

}

Copilot · 2026-02-24T14:15:41Z

+func setupImageHandlerTest(t *testing.T) (*ImageHandler, *gin.Engine) {
+	t.Helper()
 	svc := new(mockImageService)


The unused mockImageService instance svc is created but not returned, which may indicate incomplete refactoring. Consider either returning it or documenting why it's needed for side effects only.

Copilot · 2026-02-24T14:15:41Z

@@ -1,3 +1,4 @@
+


Blank line added at the beginning of the YAML file serves no purpose and should be removed.

Suggested change

poyrazK added 30 commits February 21, 2026 19:40

fix(errors): use safe type assertion and alias stdlib errors

b5533fb

build: enable forcetypeassert linter

997fac3

fix(services): improve error handling in auth and dns services

50d3f9c

feat(services): improve identity service with logging and metrics

849ea0f

fix(services): improve error masking in password reset service

2a8d131

fix(libvirt): improve error handling and safe type assertions

53db972

fix(lvm): use error wrapping in adapter

b221634

fix(postgres): use safe error comparison in autoscaling, cache, eip, …

c93b9a1

…lb, and iam repos

fix(postgres): use safe error comparison in identity, image, instance…

82e551f

…, and lb repos

fix(postgres): use safe error comparison in remaining repositories

cbbaf10

fix(repos): minor lint and error handling fixes in k8s and redis repos

e52c073

refactor(api): restructure main entry point and improve worker startup

7aa94cf

feat(api): add infrastructure and backend initialization helpers

2cba79a

test(handlers): fix accounting, audit, and auth handler tests

4772bd2

test(handlers): fix autoscaling, cache, and cluster handler tests

eb63093

test(handlers): fix container, cron, and dashboard handler tests

bb56e2b

test(handlers): fix database, elastic_ip, and event handler tests

d215bef

test(handlers): fix function, gateway, and global_lb handler tests

0208225

test(handlers): fix health, identity, and image handler tests

3154e5d

test(handlers): fix instance, instance_type, and lb handler tests

ffad52e

test(handlers): fix lifecycle, log, and notify handler tests

158a5cb

test(handlers): fix queue, rbac, and secret handler tests

26ac423

test(handlers): fix security_group, snapshot, and ssh_key handler tests

d14a70d

test(handlers): fix stack, storage, and subnet handler tests

1aacf54

test(handlers): fix tenant, volume, and vpc handler tests

d727815

test: minor fixes in websocket and accounting service tests

14315b2

test(services): improve coverage in accounting and auth internal tests

b50dd50

test(services): add auth lockout and fix auth service tests

0b9212f

test(services): improve coverage in cache and identity cache tests

5f96385

test(services): add identity cache and fix cloudlogs unit tests

40b05a1

Copilot AI review requested due to automatic review settings February 22, 2026 21:51

Copilot started reviewing on behalf of poyrazK February 22, 2026 21:52 View session

Copilot AI reviewed Feb 22, 2026

View reviewed changes

poyrazK added 2 commits February 23, 2026 00:58

fix(lint): fix thelper and testifylint issues in services and tests P…

3f9df15

…art 6

fix: resolve CI linting, test failures, and database connection leaks

a31abe1

Copilot AI review requested due to automatic review settings February 24, 2026 11:38

Copilot started reviewing on behalf of poyrazK February 24, 2026 11:38 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

poyrazK added 2 commits February 24, 2026 14:44

fix: replace assert with require for error assertions in tests to sat…

3f8e6a6

…isfy thelper and testifylint

fix: remove t.Parallel() from auth_test.go to prevent race conditions…

fef1406

… on shared DB

Copilot AI review requested due to automatic review settings February 24, 2026 11:45

Copilot started reviewing on behalf of poyrazK February 24, 2026 11:45 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

poyrazK added 2 commits February 24, 2026 14:48

fix: update mock expectations and resolve lint issues in auth_test.go

69b3c39

fix: resolve initialization cycle and rpc test failure

36332f6

Copilot AI review requested due to automatic review settings February 24, 2026 11:56

Copilot started reviewing on behalf of poyrazK February 24, 2026 11:56 View session

Copilot AI reviewed Feb 24, 2026

View reviewed changes

poyrazK added 4 commits February 24, 2026 17:01

fix(test): fix tests timing out locally and error suite

a7f5e31

style(test): convert assert to require in test services and handlers

18bd6e2

style(test): convert assert to require everywhere else and fix SonarQ…

907ad83

…ube lints

fix(ci): remove invalid version key from .golangci.yml

e396050

Copilot AI review requested due to automatic review settings February 24, 2026 14:04

Copilot AI reviewed Feb 24, 2026

View reviewed changes

poyrazK added 2 commits February 24, 2026 17:07

fix(test): suppress testifylint for malformed JSON comparison

61ad21f

fix(api): pass DB and RDB to ServiceConfig to avoid nil pointer panics

19428c4

Copilot AI review requested due to automatic review settings February 24, 2026 14:14

Copilot AI reviewed Feb 24, 2026

View reviewed changes

poyrazK merged commit d1f5d4b into main Feb 24, 2026
23 checks passed

poyrazK deleted the fix/remaining-lint-issues branch April 12, 2026 15:56

	allArgs := append([]string{"ssh"}, sshArgs...)
	allArgs := append([]string{"ssh"}, sshArgs...)
	//nolint:gosec // ssh is executed directly (no shell); user-controlled args are expected for interactive SSH

Conversation

poyrazK commented Feb 21, 2026

Overview

Changes

Lint and Error Handling

Test Coverage Improvements

Architecture and Main Entry Point

Verification

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants