tests/typing: Add tests for conversions to/from dictionary #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoonoclaste
commented
Jan 18, 2019
nicoonoclaste
force-pushed
the
tests/dict
branch
from
995bfe8 to
dee8697
Compare
Collaborator
Author
|
Rebased on #101, removed a bit of fluff from the dictionary test. |
nicoonoclaste
force-pushed
the
tests/dict
branch
from
9a0fd5e to
f6f5c1b
Compare
Member
|
Can you rebase again? Looks like another branch is still mixed in. |
Collaborator
Author
|
@astronouth7303 That's because Github doesn't notice you merged most of those commits as part of #101. I can rebase indeed. |
{'x': self.x, 'y': self.y} is literally the implementation of Vector2.asdict,
so testing that Vector2.asdict produces the same thing doesn't bring much value.
nicoonoclaste
force-pushed
the
tests/dict
branch
from
f6f5c1b to
497a9e9
Compare
Collaborator
Author
|
Done. |
Collaborator
Author
|
@astronouth7303 Any reason this can't go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second take on #104 ; still based on #101.