Skip to content

Conversation

@nicoonoclaste
Copy link
Collaborator

  • requirements-upload.txt taken from pursuedpybear;
  • .ci/upload-build.sh inspired by Cirrus CI's documentation;
  • upload task uses account pursuedpybear on Github and test.pypi.org.

- requirements-upload.txt taken from pursuedpybear;
- .ci/upload-build.sh inspired by Cirrus CI's documentation;
- upload task uses account 'pursuedpybear' on Github and test.pypi.org.
@nicoonoclaste
Copy link
Collaborator Author

nicoonoclaste commented May 26, 2019

  • @pursuedpybot needs to be invited to @ppb and granted write access to ppb-vector (or at least its release artifacts).
  • pursuedpybot needs to be granted upload access to ppb-vector (on test.pypi.org)

@AstraLuma
Copy link
Member

@nicoonoclaste
Copy link
Collaborator Author

@astronouth7303 I do not believe I have the required level of access to create an app under the PPB organisation.

@nicoonoclaste
Copy link
Collaborator Author

nicoonoclaste commented Jun 1, 2019

Re: PyPI API keys

per-user API keys as an alternative form of multifactor authentication

🙀
I hope they misspoke and didn't mean that API keys will be needed in addition to username/password (and instead of a 2FA method).

  • Each user who has upload permissions for a specific project will be able to generate API tokens via the Warehouse web UI with upload permissions for that specific project.
  • Each user will be able to view, manage, revoke, and delete their own previously generated API tokens via the Warehouse web UI.

API tokens will still be owned by specific users, so we will still need a PyPI user for the organisation.

@AstraLuma
Copy link
Member

Implement support for per-User and per-Project API Keys as PyPI API authentication tokens

@nicoonoclaste
Copy link
Collaborator Author

nicoonoclaste commented Jun 2, 2019

So, any feedback on whether we want this, and whether the 2 pursuedpybot machine users have the necessary access? If so, I'd like to merge and cut a release candidate so we can:

  1. test the latest changes work in PPB itself, before comiting to 1.0;
  2. test the release automation (against test.pypi.org) for a pre-release.

Per the discussion on Discord, we cannot currently avoid having a machine user for PyPI, and it's not obvious it is possible for a Github App; it might be possible by registering an app and manually acquiring an OAuth token, but that will require some thought and development effort.

@AstraLuma
Copy link
Member

Ok, after discussions.

Yes, this is a thing we want.

The current incarnation is fine. A full github app would require infra and no thanks right now.

Let's try to use this for the current release cycle.

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 6, 2019
161: Cirrus CI: upload build artifacts to Github and (test) PyPI r=astronouth7303 a=nbraud

- `requirements-upload.txt` taken from pursuedpybear;
- `.ci/upload-build.sh` inspired by Cirrus CI's [documentation];
- upload task uses account `pursuedpybear` on Github and `test.pypi.org`.

[documentation]: https://cirrus-ci.org/examples/#release-assets


Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors bors bot merged commit 31f80d9 into ppb:master Jun 6, 2019
@bors
Copy link
Contributor

bors bot commented Jun 6, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@nicoonoclaste nicoonoclaste deleted the ci/upload branch June 8, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants