Skip to content

Conversation

@nicoonoclaste
Copy link
Collaborator

No description provided.

@nicoonoclaste
Copy link
Collaborator Author

Not sure whether to add a test, or what it should be.

The only thing I can think of is bool(v) == (v.x == 0 and v.y == 0), and that's pretty much literally a copy-paste of the code that implements __bool__.

@AstraLuma
Copy link
Member

Given it's used everywhere, I'm going to consider it tested.

@nicoonoclaste
Copy link
Collaborator Author

@astronouth7303 OK, feel free to bors r+ if you reviewed.

@AstraLuma
Copy link
Member

bors r+

bors bot added a commit that referenced this pull request Jun 2, 2019
166: Make (non-null) vectors truth-y r=astronouth7303 a=nbraud



Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Jun 2, 2019

Build failed

  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@nicoonoclaste
Copy link
Collaborator Author

bors r=astronouth7303

bors bot added a commit that referenced this pull request Jun 2, 2019
166: Make (non-null) vectors truth-y r=astronouth7303 a=nbraud



Co-authored-by: Nicolas Braud-Santoni <nicolas@braud-santoni.eu>
@bors
Copy link
Contributor

bors bot commented Jun 2, 2019

Build succeeded

  • docs
  • FreeBSD PYTHON:3.6
  • FreeBSD PYTHON:3.7
  • lint
  • Linux python:3.6-slim
  • Linux python:3.7-slim
  • macOS PYTHON:3.6.8
  • macOS PYTHON:3.7.2
  • Windows python:3.6-windowsservercore-1809
  • Windows python:3.7-windowsservercore-1809

@bors bors bot merged commit 2b22177 into ppb:master Jun 2, 2019
@nicoonoclaste nicoonoclaste deleted the bool branch June 2, 2019 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants