Merged
Conversation
mkumatag
requested changes
Dec 2, 2022
Contributor
Author
|
This is still on my radar but I had to focus on some openshift 4.13 tasks. During a debug I found a very similar script used by calico i thought id share here as an FYI: https://github.com/projectcalico/calico/blob/master/calicoctl/calicoctl/commands/node/diags.go |
A bash script to gather network stats from ip, netstat, arp, and ethtool commands. Script will exist in root directory of image and output is saved in /home/network-snapshot-output dir with a date based on the day when the script was executed. Signed-off-by: Mick Tarsel <mtarsel@gmail.com>
mtarsel
force-pushed
the
network-snapshot
branch
from
7bb974f to
d27c536
Compare
Contributor
Author
|
@mkumatag So i removed the trailing baskslash at the top but its still causing the tests to fail so im not sure how to proceed... |
mkumatag
requested changes
Mar 3, 2023
Contributor
Author
|
Sorry about that formatting problem. Would you mind squashing this for the merge? |
|
/meow |
Contributor
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include a bash script to gather network stats. Based off brief discussion at Issue #6
Not sure most ideal way to include bash script in Dockerfile so I'm willing to redo this commit if not ideal.