Skip to content

[ADD] Reversed logic to TimeInCorporationFilter#66

Merged
ppfeufer merged 2 commits intomasterfrom
reverse-time-in-corp-lfilter
Dec 31, 2024
Merged

[ADD] Reversed logic to TimeInCorporationFilter#66
ppfeufer merged 2 commits intomasterfrom
reverse-time-in-corp-lfilter

Conversation

@ppfeufer
Copy link
Copy Markdown
Owner

@ppfeufer ppfeufer commented Dec 31, 2024

This is handy to put pilots on probation into a group, for example.

Description

Added

  • Checkbox to reverse logic for TimeInCorporationFilter, which comes in handy when you want to put characters that are not in the corporation for a certain amount of time in a group, like for a probation period.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

This is handy to put pilots on probation into a group, for example.
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.38%. Comparing base (227eb20) to head (64a600d).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   78.82%   78.38%   -0.43%     
==========================================
  Files           6        6              
  Lines         406      407       +1     
  Branches       41       41              
==========================================
- Hits          320      319       -1     
- Misses         85       87       +2     
  Partials        1        1              
Files with missing lines Coverage Δ
memberaudit_securegroups/models.py 82.66% <100.00%> (-0.62%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227eb20...64a600d. Read the comment docs.

@ppfeufer ppfeufer force-pushed the reverse-time-in-corp-lfilter branch from 182dc91 to 64a600d Compare December 31, 2024 13:59
@ppfeufer
Copy link
Copy Markdown
Owner Author

Codecov go home, you're drunk …

@ppfeufer ppfeufer merged commit 73fc330 into master Dec 31, 2024
@ppfeufer ppfeufer deleted the reverse-time-in-corp-lfilter branch December 31, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant