Skip to content

[FIX] Fail gracefully on RequestError#322

Merged
ppfeufer merged 1 commit intomasterfrom
request-error-fail-gracefully
Mar 29, 2026
Merged

[FIX] Fail gracefully on RequestError#322
ppfeufer merged 1 commit intomasterfrom
request-error-fail-gracefully

Conversation

@ppfeufer
Copy link
Copy Markdown
Owner

Description

Fixed

  • Fail gracefully on RequestError, which can be thrown by django-esi when ESI is
    unavailable, instead of crashing the task (Downtime, Endpoint down, etc.)

Type of Change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have checked my code and corrected any misspellings

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (ced9eda) to head (2486239).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #322   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          309       309           
  Branches        18        18           
=========================================
  Hits           309       309           
Files with missing lines Coverage Δ
sovtimer/providers.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ced9eda...2486239. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ppfeufer ppfeufer merged commit 729e054 into master Mar 29, 2026
56 checks passed
@ppfeufer ppfeufer deleted the request-error-fail-gracefully branch March 29, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant