feat: optimize graph rendering performance and improve animation hand…#8
Merged
feat: optimize graph rendering performance and improve animation hand…#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
GraphRendererclass insrc/components/graph-renderer.tsto optimize performance and improve code readability. The main changes include moving static constants out of hot code paths, pre-computing scale-dependent values, and replacing array allocations with more efficient loops and flat push patterns. These updates reduce unnecessary allocations and repeated calculations, making the rendering logic faster and easier to maintain.Performance and allocation optimizations:
SIZE_PRESETS,MONTHS, lerp arrays) to class-level properties to avoid repeated allocation and prototype lookups in hot code paths.sc14,sc42) and used these throughout the rendering logic for font sizes, positions, and dimensions. [1] [2] [3]Array.mapandArray.fromto flat push loops, reducing intermediate array allocations and improving performance for large graphs. [1] [2]Rendering logic improvements:
.toFixedcalls inside loops.Dateobjects.SVG structure and animation improvements: