Skip to content

Update templates #2

Merged
hagenmuenkler merged 13 commits intoppqm:masterfrom
hagenmuenkler:feature/templates
Apr 14, 2026
Merged

Update templates #2
hagenmuenkler merged 13 commits intoppqm:masterfrom
hagenmuenkler:feature/templates

Conversation

@hagenmuenkler
Copy link
Copy Markdown
Contributor

A suggestion to modify the functions that generate the scripts to be submitted. The main changes are:

  • rely only on a single template that should be able to cover all scenarios
  • Use a pydantic model to check the configuration for the UGE settings

TEMPLATE_SINGLE = Path(__file__).parent / "templates" / "submit-normal.jinja"
TEMPLATE_HOLDING = Path(__file__).parent / "templates" / "submit-holding.jinja"
MASTER_TEMPLATE = Path(__file__).parent / "templates" / "submit_template.jinja"
# TEMPLATE_TASKARRAY = Path(__file__).parent / "templates" / "submit-task-array.jinja"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused code

Comment thread tests/uge/test_submitting.py Outdated
task_concurrent=1,
task_stop=2,
script: str = generate_script(
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@charnley
Copy link
Copy Markdown
Member

LGTM

@hagenmuenkler hagenmuenkler merged commit a45b134 into ppqm:master Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants