Skip to content

Add missing Linux libraries to build.sh#278

Merged
Susko3 merged 1 commit intoppy:masterfrom
Kenji-NX:linux-build
Apr 29, 2026
Merged

Add missing Linux libraries to build.sh#278
Susko3 merged 1 commit intoppy:masterfrom
Kenji-NX:linux-build

Conversation

@KeatonTheBot
Copy link
Copy Markdown
Contributor

Add Linux libraries libjack and libusb to build.sh. The latter fixes an issue with the Nintendo Switch 2 Pro Controller, as outlined here: Ryubing/Issues#318.

@Susko3
Copy link
Copy Markdown
Member

Susko3 commented Apr 28, 2026

I've looked through the linked issue and the downstream PR, but it wasn't mentioned how this fixes the issue. Do you know the mechanism of how including these libraries fixes the problem? Will those libraries be a hard pre-requisite for end-users with this change?

@KeatonTheBot
Copy link
Copy Markdown
Contributor Author

KeatonTheBot commented Apr 28, 2026

I've looked through the linked issue and the downstream PR, but it wasn't mentioned how this fixes the issue. Do you know the mechanism of how including these libraries fixes the problem? Will those libraries be a hard pre-requisite for end-users with this change?

According to these variables, libusb is an optional dependency:
SDL_HINT_HIDAPI_LIBUSB
SDL_HINT_HIDAPI_LIBUSB_WHITELIST

Copy link
Copy Markdown
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems probably okay to me? @Susko3 will leave the merge in your hands

Copy link
Copy Markdown
Member

@Susko3 Susko3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks fine to me. If this breaks stuff for users, they can disable it with the hint.

@Susko3 Susko3 merged commit 8918d10 into ppy:master Apr 29, 2026
4 checks passed
@smoogipoo
Copy link
Copy Markdown
Contributor

Thanks. Available as 2026.429.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants