Add a passing and a failing test for Korean IME#6745
Merged
Conversation
The tests are based on actual events reported by SDL3.
Merged
bdach
approved these changes
May 11, 2026
This was referenced May 12, 2026
This was referenced May 18, 2026
This was referenced Jun 16, 2026
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests the problem as reported in ppy/osu#37601. The tests are based on actual events reported by SDL3 when using Microsoft Korean IME on Windows, but modified to use characters supported by o!f fonts instead of Hangul.
TestKoreanImeFinalizeByNonLetter passes on master, while TestKoreanImeFinalizeByNewComposition fails the last two asserts.
Applying #6742 makes the second test pass, as you would expect.
I would suggest merging this either directly before or directly after #6742.