Skip to content

Improve fullcombo threshold formula#35724

Merged
stanriders merged 5 commits into
ppy:pp-devfrom
Givikap120:better-fullcombo-threshold
Jan 3, 2026
Merged

Improve fullcombo threshold formula#35724
stanriders merged 5 commits into
ppy:pp-devfrom
Givikap120:better-fullcombo-threshold

Conversation

@Givikap120

@Givikap120 Givikap120 commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

It used to always take 10%.
Now it's down to 5% if map has no hard sliders, since in this case probability of dropping many sliderends is low.
For maps with hard sliders the portion can reach up to 20%.

@stanriders

Copy link
Copy Markdown
Member

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#35724

@tsunyoku

Copy link
Copy Markdown
Member

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#35724

@github-actions

Copy link
Copy Markdown

@Givikap120

Givikap120 commented Nov 25, 2025

Copy link
Copy Markdown
Contributor Author

Those are results (green are correct prediction, red is incorrect):

image image

I think it should be made harsher for high top weighted slider factor values.
All the red scores on second screenshot are stream maps with very big amount of sliderends missed.

@tsunyoku

Copy link
Copy Markdown
Member

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#35724

@github-actions

Copy link
Copy Markdown

@Givikap120

Copy link
Copy Markdown
Contributor Author

Updated.
First three green greens scores are sliderbreak on the slider right before the final spinner, unlucky, missing only 3 combo.
Two new "red" maps in the first screenshot are very slider-heavy maps with SB at the end, so it's quite reasonable.
image
On the second screenshot there's one red less, and few more greens. Two remaining reds are stream maps with very unreasonable amount of missed sliderends (14 sliderend misses).
image

Comment thread osu.Game.Rulesets.Osu/Difficulty/OsuLegacyScoreMissCalculator.cs
@stanriders stanriders merged commit bcaf35d into ppy:pp-dev Jan 3, 2026
4 of 8 checks passed
@github-project-automation github-project-automation Bot moved this from Pending Review to Pending Deploy in Difficulty calculation changes Jan 3, 2026
Moyazuk pushed a commit to Moyazuk/osu that referenced this pull request Jan 25, 2026
* Implement new portion formula

* Change the formula

* Use base value of 5 sliders

* Make the threshold harsher

---------

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>
Moyazuk pushed a commit to Moyazuk/osu that referenced this pull request Jan 25, 2026
* Implement new portion formula

* Change the formula

* Use base value of 5 sliders

* Make the threshold harsher

---------

Co-authored-by: StanR <8269193+stanriders@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Pending Deploy

Development

Successfully merging this pull request may close these issues.

4 participants