Remove DrainRate difficulty attribute#35817
Merged
Merged
Conversation
stanriders
approved these changes
Nov 26, 2025
stanriders
left a comment
stanriders
left a comment
Member
There was a problem hiding this comment.
I think it got lost in the middle of the ar/od->diffcalc refactor because of the BL? Not sure
Member
|
I was mainly concerned with reducing database storage and since this one isn't databased I probably just left it. This also works though. |
tsunyoku
approved these changes
Nov 29, 2025
github-project-automation
Bot
moved this from Pending Review
to Pending Deploy
in Difficulty calculation changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know how this was missed when removing AR and OD attributes, but here.
It wasn't stored in the database (it was local-only attribute), but I think it's weird why it's here when AR and OD aren't.