Fix mania hold notes dimming unexpectedly#37008
Merged
bdach merged 8 commits intoppy:masterfrom Mar 23, 2026
Merged
Conversation
These seem to be unnecessary due to DHO's transform reset.
bdach
reviewed
Mar 18, 2026
Nested hitobjects receive `OnApply()` first, which would cause them to apply the (now stale) dim state.
bdach
requested changes
Mar 19, 2026
bdach
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29223
This fixes several issues around hold note dimming.
Notice in the following video:
2026-03-17.19-42-26.mp4
Then, notice in the following video:
2026-03-17.19-42-53.mp4
This requires a specific setup whereby the hold note and its components must be reused from the pool. In particular:
Column.cs.I haven't done a full deep dive into exactly why this is happening, so the fix here is hand-wavy. That said, just by looking at the old code in
LegacyBodyPieceyou'll get a feeling that something's bound to go wrong;missingFadeTimestate.Color4.White.missingFadeTime.My hope is that these changes first bring some sanity in the process, and if it breaks again I'll consider doing a more proper root cause (I've had this issue in the back of my mind for about 1 year).
With this PR, they now behave as expected:
2026-03-17.19-43-59.mp4
2026-03-17.19-44-15.mp4