Port: add --aarch64-fips202-backend to tests and CI#683
Merged
Conversation
mkannwischer
requested changes
Nov 12, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. This looks mostly good. There is one CI warning - please resolve that before we merge. I'll think about if we should port the check_namespace script or not - the value it adds seems very limited.
mkannwischer
approved these changes
Nov 12, 2025
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks for the update. LGTM.
- This commit is ported from mlkem-native PR #1106. - This commit adds the `--aarch64-fips202-backend` option to the `tests` scripts, allowing the FIPS202 backend to be specified directly as an input parameter, also adds backend_tests to the CI workflow. Signed-off-by: willieyz <willie.zhao@chelpis.com>
hanno-becker
force-pushed
the
issue-621
branch
from
7bc795b to
8d636be
Compare
hanno-becker
added a commit
that referenced
this pull request
May 13, 2026
Replace the single-layer C-reference forward and inverse NTT in
`mldsa/src/poly.c` with one that merges two layers each.
Also, store each twiddle alongside its precomputed twist, letting
`mld_fqmul(a, b, b_twisted)` drop the multiply with MLDSA_Q^{-1}
that was previously hidden inside `mld_montgomery_reduce`.
Mirrors pq-code-package/mlkem-native/#463 and pq-code/package/mlkem-native/#683
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
hanno-becker
added a commit
that referenced
this pull request
May 13, 2026
Replace the single-layer C-reference forward and inverse NTT in
`mldsa/src/poly.c` with one that merges two layers each.
Also, store each twiddle alongside its precomputed twist, letting
`mld_fqmul(a, b, b_twisted)` drop the multiply with MLDSA_Q^{-1}
that was previously hidden inside `mld_montgomery_reduce`.
Mirrors pq-code-package/mlkem-native/#463 and pq-code/package/mlkem-native/#683
Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: Port: Add --aarch64-fips202-backend to tests #621
This PR is ported from mlkem-native PR Documentation: Convert to Doxygen-style function headers and lint #1106.
This PR adds the
--aarch64-fips202-backendoption to thetestsscripts, allowing the FIPS202 backend to be specified directly as an input parameter, this makes testing different FIPS202 AArch64 backends easier, also addsbackend_teststo the CI workflow.