linting: add shellcheck for shell script lint by L-series · Pull Request #756 · pq-code-package/mldsa-native

L-series · 2025-12-01T00:41:28Z

Add linting for shell scripts in the scipts directory as well as any
*.sh file accross the project using shellcheck.

hanno-becker

Thank you @L-series, in general I think linting the shell scripts is a great idea -- esp. seeing that at least I'm not a shell expert.

However, it looks like some of the quoting has broken scripts/lint, at least the Lint Shell command. Can you have a look, both at the issue itself and why the CI did not catch it?

L-series · 2025-12-01T19:49:56Z

@hanno-becker Hello, please see my comment above regarding what the issue was with the shfmt syntax. I've changed that syntax and I simplified the logic behind the shellcheck implementation.

I'm adding a variable which tracks the shells scripts which exist across the project and I pass that to both shfmt and shellcheck instead of recomputing it for shellcheck.

hanno-becker · 2026-01-22T05:27:52Z

@L-series Can you rebase and make sure this is aligned with pq-code-package/mlkem-native#1329?

L-series · 2026-01-22T15:37:38Z

@hanno-becker The patchset should now be inline with the mlkem implementation!

oqs-bot · 2026-01-22T16:17:10Z

CBMC Results (ML-DSA-44)

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	1849s	1808s	+2.3%
`mld_attempt_signature_generation`	✅	224s	213s	+5%
`polyvecl_pointwise_acc_montgomery_c`	✅	193s	186s	+4%
`poly_pointwise_montgomery_c`	✅	130s	130s	+0%
`rej_uniform_native`	✅	128s	124s	+3%
`sign_verify_internal`	✅	119s	117s	+2%
`mld_ct_memcmp`	✅	81s	74s	+9%
`mld_invntt_layer`	✅	72s	70s	+3%
`keccak_squeezeblocks_x4`	✅	44s	47s	-6%
`mld_ntt_layer`	✅	44s	43s	+2%
`sign_signature_internal`	✅	35s	34s	+3%
`fqmul`	✅	22s	21s	+5%
`rej_uniform`	✅	21s	21s	+0%
`polyt0_unpack`	✅	18s	13s	+38%
`rej_uniform_c`	✅	17s	17s	+0%
`poly_chknorm_c`	✅	16s	15s	+7%
`poly_uniform_eta_4x`	✅	15s	16s	-6%
`polymat_permute_bitrev_to_custom`	✅	15s	15s	+0%
`polyvec_matrix_expand`	✅	15s	15s	+0%
`mld_compute_t0_t1_tr_from_sk_components`	✅	14s	12s	+17%
`poly_uniform_4x`	✅	14s	13s	+8%
`polyeta_unpack`	✅	14s	13s	+8%
`keccak_absorb_once_x4`	✅	13s	13s	+0%
`keccakf1600x4_permute_native`	✅	13s	13s	+0%
`mld_ntt_butterfly_block`	✅	12s	11s	+9%
`polyz_unpack_c`	✅	12s	11s	+9%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	11s	7s	+57%
`polyveck_add`	✅	10s	6s	+67%
`mld_check_pct`	✅	9s	7s	+29%
`poly_invntt_tomont_c`	✅	9s	11s	-18%
`keccakf1600_permute_native`	✅	8s	8s	+0%
`mld_compute_pack_z`	✅	8s	6s	+33%
`polyvec_matrix_expand_serial`	✅	8s	6s	+33%
`polyveck_decompose`	✅	8s	6s	+33%
`polyveck_pointwise_poly_montgomery`	✅	8s	5s	+60%
`keccakf1600_permute`	✅	7s	6s	+17%
`polyveck_ntt`	✅	7s	5s	+40%
`polyvecl_chknorm`	✅	7s	6s	+17%
`sign`	✅	7s	7s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	6s	7s	-14%
`polyveck_caddq`	✅	6s	5s	+20%
`polyveck_pack_eta`	✅	6s	3s	+100%
`polyveck_power2round`	✅	6s	4s	+50%
`rej_eta_c`	✅	6s	5s	+20%
`sign_keypair_internal`	✅	6s	5s	+20%
`sign_verify`	✅	6s	6s	+0%
`mld_sample_s1_s2`	✅	5s	4s	+25%
`mld_sample_s1_s2_serial`	✅	5s	5s	+0%
`pack_sig_z`	✅	5s	4s	+25%
`poly_uniform_gamma1_4x`	✅	5s	5s	+0%
`polyveck_invntt_tomont`	✅	5s	5s	+0%
`polyveck_reduce`	✅	5s	3s	+67%
`polyveck_use_hint`	✅	5s	3s	+67%
`shake128x4_squeezeblocks`	✅	5s	3s	+67%
`sign_open`	✅	5s	7s	-29%
`sign_pk_from_sk`	✅	5s	6s	-17%
`sign_verify_pre_hash_shake256`	✅	5s	6s	-17%
`sys_check_capability`	✅	5s	4s	+25%
`unpack_hints`	✅	5s	6s	-17%
`unpack_sk`	✅	5s	3s	+67%
`keccak_absorb`	✅	4s	7s	-43%
`keccak_finalize`	✅	4s	4s	+0%
`keccak_squeeze`	✅	4s	3s	+33%
`make_hint`	✅	4s	2s	+100%
`mld_ct_cmask_nonzero_u8`	✅	4s	2s	+100%
`mld_h`	✅	4s	7s	-43%
`mld_prepare_domain_separation_prefix`	✅	4s	2s	+100%
`mld_value_barrier_i64`	✅	4s	4s	+0%
`pack_pk`	✅	4s	3s	+33%
`pack_sig_c_h`	✅	4s	4s	+0%
`poly_add`	✅	4s	2s	+100%
`poly_challenge`	✅	4s	4s	+0%
`poly_invntt_tomont_native`	✅	4s	2s	+100%
`poly_ntt_c`	✅	4s	2s	+100%
`poly_ntt_native`	✅	4s	4s	+0%
`poly_sub`	✅	4s	2s	+100%
`poly_uniform_eta`	✅	4s	4s	+0%
`poly_use_hint`	✅	4s	2s	+100%
`poly_use_hint_c`	✅	4s	3s	+33%
`poly_use_hint_native`	✅	4s	3s	+33%
`polyt1_pack`	✅	4s	2s	+100%
`polyveck_chknorm`	✅	4s	3s	+33%
`polyveck_make_hint`	✅	4s	5s	-20%
`polyveck_shiftl`	✅	4s	3s	+33%
`polyveck_unpack_t0`	✅	4s	2s	+100%
`polyvecl_ntt`	✅	4s	6s	-33%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	5s	-20%
`polyvecl_unpack_z`	✅	4s	4s	+0%
`polyz_pack`	✅	4s	2s	+100%
`power2round`	✅	4s	3s	+33%
`rej_eta_native`	✅	4s	5s	-20%
`shake256`	✅	4s	3s	+33%
`shake256_finalize`	✅	4s	2s	+100%
`shake256_release`	✅	4s	3s	+33%
`shake256x4_squeezeblocks`	✅	4s	3s	+33%
`sign_verify_extmu`	✅	4s	7s	-43%
`use_hint`	✅	4s	3s	+33%
`fqscale`	✅	3s	3s	+0%
`keccak_init`	✅	3s	2s	+50%
`mld_ct_sel_int32`	✅	3s	2s	+50%
`mld_value_barrier_u8`	✅	3s	3s	+0%
`ntt_native_x86_64`	✅	3s	4s	-25%
`poly_caddq`	✅	3s	3s	+0%
`poly_caddq_c`	✅	3s	2s	+50%
`poly_caddq_native`	✅	3s	3s	+0%
`poly_chknorm`	✅	3s	4s	-25%
`poly_decompose_c`	✅	3s	3s	+0%
`poly_decompose_native`	✅	3s	5s	-40%
`poly_invntt_tomont`	✅	3s	3s	+0%
`poly_make_hint`	✅	3s	3s	+0%
`poly_ntt`	✅	3s	5s	-40%
`poly_pointwise_montgomery_native`	✅	3s	3s	+0%
`poly_power2round`	✅	3s	3s	+0%
`poly_uniform`	✅	3s	4s	-25%
`polyt0_pack`	✅	3s	4s	-25%
`polyveck_pack_t0`	✅	3s	4s	-25%
`polyveck_pack_w1`	✅	3s	6s	-50%
`polyveck_sub`	✅	3s	5s	-40%
`polyveck_unpack_eta`	✅	3s	3s	+0%
`polyvecl_pack_eta`	✅	3s	3s	+0%
`polyvecl_permute_bitrev_to_custom`	✅	3s	3s	+0%
`polyvecl_uniform_gamma1`	✅	3s	4s	-25%
`polyvecl_uniform_gamma1_serial`	✅	3s	2s	+50%
`polyvecl_unpack_eta`	✅	3s	2s	+50%
`polyw1_pack`	✅	3s	5s	-40%
`polyz_unpack_native`	✅	3s	2s	+50%
`rej_eta`	✅	3s	5s	-40%
`shake128x4_absorb_once`	✅	3s	2s	+50%
`shake256_absorb`	✅	3s	2s	+50%
`shake256_init`	✅	3s	4s	-25%
`sign_signature`	✅	3s	3s	+0%
`sign_signature_extmu`	✅	3s	4s	-25%
`sign_signature_pre_hash_shake256`	✅	3s	4s	-25%
`unpack_pk`	✅	3s	2s	+50%
`caddq`	✅	2s	3s	-33%
`decompose`	✅	2s	6s	-67%
`keccakf1600_xor_bytes`	✅	2s	1s	+100%
`keccakf1600_xor_bytes (big endian)`	✅	2s	3s	-33%
`keccakf1600x4_extract_bytes`	✅	2s	2s	+0%
`mld_ct_abs_i32`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u32`	✅	2s	1s	+100%
`mld_keccakf1600_extract_bytes`	✅	2s	3s	-33%
`mld_value_barrier_u32`	✅	2s	2s	+0%
`poly_chknorm_native`	✅	2s	2s	+0%
`poly_decompose`	✅	2s	3s	-33%
`poly_pointwise_montgomery`	✅	2s	5s	-60%
`poly_reduce`	✅	2s	3s	-33%
`poly_shiftl`	✅	2s	2s	+0%
`polyeta_pack`	✅	2s	5s	-60%
`polyt1_unpack`	✅	2s	4s	-50%
`polyvecl_pointwise_acc_montgomery`	✅	2s	4s	-50%
`polyz_unpack`	✅	2s	4s	-50%
`reduce32`	✅	2s	4s	-50%
`shake128_absorb`	✅	2s	2s	+0%
`shake128_init`	✅	2s	3s	-33%
`shake128_release`	✅	2s	3s	-33%
`shake128_squeeze`	✅	2s	2s	+0%
`shake256_squeeze`	✅	2s	2s	+0%
`shake256x4_absorb_once`	✅	2s	3s	-33%
`sign_keypair`	✅	2s	5s	-60%
`sign_signature_pre_hash_internal`	✅	2s	4s	-50%
`sign_verify_pre_hash_internal`	✅	2s	3s	-33%
`unpack_sig`	✅	2s	3s	-33%
`keccakf1600_extract_bytes (big endian)`	✅	1s	2s	-50%
`keccakf1600x4_permute`	✅	1s	1s	+0%
`keccakf1600x4_xor_bytes`	✅	1s	4s	-75%
`mld_ct_cmask_neg_i32`	✅	1s	2s	-50%
`mld_ct_cmask_nonzero_u32`	✅	1s	2s	-50%
`mld_ct_get_optblocker_u8`	✅	1s	1s	+0%
`montgomery_reduce`	✅	1s	4s	-75%
`pack_sk`	✅	1s	3s	-67%
`poly_uniform_gamma1`	✅	1s	3s	-67%
`shake128_finalize`	✅	1s	2s	-50%

oqs-bot · 2026-01-22T16:17:20Z

CBMC Results (ML-DSA-87)

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2232s	2117s	+5.4%
`mld_attempt_signature_generation`	✅	200s	191s	+5%
`polyvec_matrix_expand`	✅	199s	190s	+5%
`polyvecl_pointwise_acc_montgomery_c`	✅	177s	156s	+13%
`poly_pointwise_montgomery_c`	✅	146s	128s	+14%
`rej_uniform_native`	✅	127s	125s	+2%
`sign_verify_internal`	✅	120s	116s	+3%
`polyvec_matrix_expand_serial`	✅	106s	103s	+3%
`mld_ct_memcmp`	✅	85s	76s	+12%
`mld_invntt_layer`	✅	63s	59s	+7%
`sign_signature_internal`	✅	59s	58s	+2%
`mld_ntt_layer`	✅	46s	42s	+10%
`keccak_squeezeblocks_x4`	✅	44s	44s	+0%
`mld_compute_t0_t1_tr_from_sk_components`	✅	25s	26s	-4%
`polymat_permute_bitrev_to_custom`	✅	24s	23s	+4%
`rej_uniform`	✅	23s	20s	+15%
`fqmul`	✅	19s	18s	+6%
`poly_uniform_eta_4x`	✅	19s	17s	+12%
`poly_chknorm_c`	✅	17s	15s	+13%
`polyt0_unpack`	✅	17s	14s	+21%
`rej_uniform_c`	✅	17s	17s	+0%
`keccakf1600x4_permute_native`	✅	16s	14s	+14%
`poly_uniform_4x`	✅	14s	12s	+17%
`polyveck_add`	✅	14s	13s	+8%
`keccak_absorb_once_x4`	✅	13s	13s	+0%
`polyvec_matrix_pointwise_montgomery`	✅	13s	13s	+0%
`polyveck_power2round`	✅	13s	12s	+8%
`mld_ntt_butterfly_block`	✅	12s	12s	+0%
`polyeta_unpack`	✅	12s	13s	-8%
`poly_decompose_c`	✅	11s	8s	+38%
`polyveck_use_hint`	✅	11s	8s	+38%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	10s	12s	-17%
`polyveck_reduce`	✅	10s	11s	-9%
`poly_invntt_tomont_c`	✅	9s	8s	+12%
`sign`	✅	9s	7s	+29%
`mld_check_pct`	✅	8s	5s	+60%
`mld_sample_s1_s2_serial`	✅	8s	6s	+33%
`polyveck_ntt`	✅	8s	6s	+33%
`polyveck_unpack_eta`	✅	8s	5s	+60%
`polyvecl_ntt`	✅	8s	10s	-20%
`sign_pk_from_sk`	✅	8s	9s	-11%
`keccak_absorb`	✅	7s	8s	-12%
`keccakf1600_permute`	✅	7s	9s	-22%
`keccakf1600_permute_native`	✅	7s	6s	+17%
`polyveck_chknorm`	✅	7s	7s	+0%
`polyveck_decompose`	✅	7s	6s	+17%
`polyveck_invntt_tomont`	✅	7s	9s	-22%
`polyveck_make_hint`	✅	7s	6s	+17%
`polyveck_pointwise_poly_montgomery`	✅	7s	7s	+0%
`polyveck_sub`	✅	7s	7s	+0%
`unpack_sk`	✅	7s	4s	+75%
`mld_sample_s1_s2`	✅	6s	6s	+0%
`poly_decompose_native`	✅	6s	3s	+100%
`poly_use_hint_native`	✅	6s	4s	+50%
`polyveck_caddq`	✅	6s	9s	-33%
`polyveck_pack_t0`	✅	6s	4s	+50%
`polyveck_shiftl`	✅	6s	6s	+0%
`polyz_unpack_c`	✅	6s	5s	+20%
`shake128x4_absorb_once`	✅	6s	5s	+20%
`sign_keypair`	✅	6s	3s	+100%
`sign_signature_pre_hash_internal`	✅	6s	5s	+20%
`mld_compute_pack_z`	✅	5s	5s	+0%
`poly_uniform`	✅	5s	2s	+150%
`poly_uniform_eta`	✅	5s	2s	+150%
`poly_uniform_gamma1_4x`	✅	5s	4s	+25%
`polyt0_pack`	✅	5s	4s	+25%
`polyt1_pack`	✅	5s	4s	+25%
`polyvecl_chknorm`	✅	5s	5s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	5s	4s	+25%
`polyvecl_uniform_gamma1`	✅	5s	4s	+25%
`polyz_unpack_native`	✅	5s	3s	+67%
`rej_eta_c`	✅	5s	5s	+0%
`sign_keypair_internal`	✅	5s	6s	-17%
`unpack_pk`	✅	5s	4s	+25%
`caddq`	✅	4s	3s	+33%
`keccakf1600_extract_bytes (big endian)`	✅	4s	1s	+300%
`keccakf1600_xor_bytes`	✅	4s	3s	+33%
`mld_ct_get_optblocker_i64`	✅	4s	3s	+33%
`mld_h`	✅	4s	6s	-33%
`mld_prepare_domain_separation_prefix`	✅	4s	5s	-20%
`mld_value_barrier_i64`	✅	4s	5s	-20%
`pack_pk`	✅	4s	4s	+0%
`poly_add`	✅	4s	3s	+33%
`poly_challenge`	✅	4s	5s	-20%
`poly_chknorm_native`	✅	4s	4s	+0%
`poly_ntt_native`	✅	4s	1s	+300%
`polyt1_unpack`	✅	4s	2s	+100%
`polyveck_unpack_t0`	✅	4s	4s	+0%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	3s	+33%
`polyvecl_uniform_gamma1_serial`	✅	4s	5s	-20%
`polyvecl_unpack_eta`	✅	4s	2s	+100%
`polyvecl_unpack_z`	✅	4s	6s	-33%
`polyw1_pack`	✅	4s	4s	+0%
`power2round`	✅	4s	3s	+33%
`shake256_release`	✅	4s	4s	+0%
`shake256_squeeze`	✅	4s	2s	+100%
`sign_open`	✅	4s	4s	+0%
`sign_signature_pre_hash_shake256`	✅	4s	4s	+0%
`sign_verify`	✅	4s	5s	-20%
`sign_verify_extmu`	✅	4s	3s	+33%
`sign_verify_pre_hash_internal`	✅	4s	2s	+100%
`sys_check_capability`	✅	4s	3s	+33%
`unpack_hints`	✅	4s	6s	-33%
`fqscale`	✅	3s	2s	+50%
`keccak_finalize`	✅	3s	6s	-50%
`keccak_init`	✅	3s	2s	+50%
`keccak_squeeze`	✅	3s	4s	-25%
`keccakf1600x4_extract_bytes`	✅	3s	3s	+0%
`keccakf1600x4_permute`	✅	3s	3s	+0%
`make_hint`	✅	3s	5s	-40%
`mld_ct_abs_i32`	✅	3s	2s	+50%
`mld_ct_cmask_nonzero_u32`	✅	3s	3s	+0%
`mld_ct_cmask_nonzero_u8`	✅	3s	3s	+0%
`mld_value_barrier_u8`	✅	3s	2s	+50%
`ntt_native_x86_64`	✅	3s	4s	-25%
`pack_sig_z`	✅	3s	3s	+0%
`poly_caddq_native`	✅	3s	4s	-25%
`poly_chknorm`	✅	3s	5s	-40%
`poly_decompose`	✅	3s	3s	+0%
`poly_invntt_tomont_native`	✅	3s	2s	+50%
`poly_ntt_c`	✅	3s	4s	-25%
`poly_pointwise_montgomery`	✅	3s	5s	-40%
`poly_power2round`	✅	3s	2s	+50%
`poly_reduce`	✅	3s	1s	+200%
`poly_sub`	✅	3s	2s	+50%
`poly_use_hint`	✅	3s	4s	-25%
`poly_use_hint_c`	✅	3s	3s	+0%
`polyveck_pack_w1`	✅	3s	2s	+50%
`polyvecl_pack_eta`	✅	3s	2s	+50%
`polyz_unpack`	✅	3s	4s	-25%
`reduce32`	✅	3s	3s	+0%
`rej_eta_native`	✅	3s	5s	-40%
`shake128_init`	✅	3s	3s	+0%
`shake128x4_squeezeblocks`	✅	3s	3s	+0%
`shake256_init`	✅	3s	3s	+0%
`shake256x4_absorb_once`	✅	3s	2s	+50%
`sign_signature`	✅	3s	2s	+50%
`sign_verify_pre_hash_shake256`	✅	3s	3s	+0%
`unpack_sig`	✅	3s	4s	-25%
`use_hint`	✅	3s	3s	+0%
`decompose`	✅	2s	4s	-50%
`keccakf1600_xor_bytes (big endian)`	✅	2s	2s	+0%
`keccakf1600x4_xor_bytes`	✅	2s	2s	+0%
`mld_ct_cmask_neg_i32`	✅	2s	2s	+0%
`mld_ct_get_optblocker_u32`	✅	2s	4s	-50%
`mld_ct_get_optblocker_u8`	✅	2s	3s	-33%
`montgomery_reduce`	✅	2s	2s	+0%
`pack_sig_c_h`	✅	2s	2s	+0%
`pack_sk`	✅	2s	3s	-33%
`poly_caddq`	✅	2s	3s	-33%
`poly_caddq_c`	✅	2s	1s	+100%
`poly_invntt_tomont`	✅	2s	3s	-33%
`poly_make_hint`	✅	2s	4s	-50%
`poly_ntt`	✅	2s	3s	-33%
`poly_pointwise_montgomery_native`	✅	2s	2s	+0%
`poly_shiftl`	✅	2s	2s	+0%
`poly_uniform_gamma1`	✅	2s	2s	+0%
`polyeta_pack`	✅	2s	3s	-33%
`polyveck_pack_eta`	✅	2s	4s	-50%
`polyvecl_permute_bitrev_to_custom`	✅	2s	2s	+0%
`polyz_pack`	✅	2s	3s	-33%
`rej_eta`	✅	2s	1s	+100%
`shake128_release`	✅	2s	2s	+0%
`shake256`	✅	2s	3s	-33%
`shake256_absorb`	✅	2s	4s	-50%
`shake256_finalize`	✅	2s	3s	-33%
`shake256x4_squeezeblocks`	✅	2s	4s	-50%
`sign_signature_extmu`	✅	2s	3s	-33%
`mld_ct_sel_int32`	✅	1s	3s	-67%
`mld_keccakf1600_extract_bytes`	✅	1s	3s	-67%
`mld_value_barrier_u32`	✅	1s	2s	-50%
`shake128_absorb`	✅	1s	2s	-50%
`shake128_finalize`	✅	1s	1s	+0%
`shake128_squeeze`	✅	1s	3s	-67%

oqs-bot · 2026-01-22T16:19:25Z

CBMC Results (ML-DSA-65)

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
`TOTAL`	✅	2506s	2573s	-2.6%
`mld_attempt_signature_generation`	✅	422s	439s	-4%
`polyvecl_pointwise_acc_montgomery_c`	✅	262s	258s	+2%
`sign_verify_internal`	✅	181s	184s	-2%
`poly_pointwise_montgomery_c`	✅	156s	160s	-3%
`polyvec_matrix_expand`	✅	138s	144s	-4%
`rej_uniform_native`	✅	137s	136s	+1%
`mld_ct_memcmp`	✅	89s	94s	-5%
`polyvec_matrix_expand_serial`	✅	66s	71s	-7%
`mld_invntt_layer`	✅	62s	67s	-7%
`sign_signature_internal`	✅	48s	50s	-4%
`keccak_squeezeblocks_x4`	✅	47s	46s	+2%
`mld_ntt_layer`	✅	43s	50s	-14%
`mld_compute_t0_t1_tr_from_sk_components`	✅	25s	27s	-7%
`rej_uniform_c`	✅	22s	24s	-8%
`fqmul`	✅	21s	22s	-5%
`rej_uniform`	✅	21s	23s	-9%
`polymat_permute_bitrev_to_custom`	✅	20s	20s	+0%
`polyveck_decompose`	✅	18s	20s	-10%
`poly_uniform_eta_4x`	✅	17s	19s	-11%
`polyvec_matrix_pointwise_montgomery`	✅	17s	16s	+6%
`polyt0_unpack`	✅	16s	20s	-20%
`keccakf1600x4_permute_native`	✅	15s	14s	+7%
`keccak_absorb_once_x4`	✅	13s	15s	-13%
`poly_uniform_4x`	✅	13s	15s	-13%
`polyveck_use_hint`	✅	13s	15s	-13%
`sign`	✅	13s	12s	+8%
`mld_check_pct`	✅	12s	12s	+0%
`mld_ntt_butterfly_block`	✅	12s	12s	+0%
`poly_chknorm_c`	✅	12s	16s	-25%
`polyveck_power2round`	✅	11s	8s	+38%
`poly_invntt_tomont_c`	✅	10s	11s	-9%
`polyveck_add`	✅	10s	8s	+25%
`polyveck_caddq`	✅	10s	7s	+43%
`polyveck_shiftl`	✅	10s	6s	+67%
`keccakf1600_permute`	✅	9s	10s	-10%
`mld_polyvecl_permute_bitrev_to_custom_native`	✅	9s	8s	+12%
`poly_decompose_c`	✅	9s	8s	+12%
`polyveck_pointwise_poly_montgomery`	✅	9s	5s	+80%
`polyveck_sub`	✅	9s	7s	+29%
`sign_pk_from_sk`	✅	9s	9s	+0%
`keccakf1600_permute_native`	✅	8s	9s	-11%
`polyveck_ntt`	✅	8s	8s	+0%
`polyveck_reduce`	✅	8s	6s	+33%
`unpack_hints`	✅	8s	5s	+60%
`mld_compute_pack_z`	✅	7s	4s	+75%
`poly_uniform_eta`	✅	7s	5s	+40%
`polyveck_invntt_tomont`	✅	7s	11s	-36%
`polyveck_make_hint`	✅	7s	7s	+0%
`polyvecl_ntt`	✅	7s	7s	+0%
`mld_sample_s1_s2`	✅	6s	5s	+20%
`mld_sample_s1_s2_serial`	✅	6s	4s	+50%
`poly_make_hint`	✅	6s	4s	+50%
`poly_use_hint_c`	✅	6s	5s	+20%
`sign_keypair_internal`	✅	6s	4s	+50%
`keccak_absorb`	✅	5s	6s	-17%
`keccakf1600x4_extract_bytes`	✅	5s	2s	+150%
`poly_add`	✅	5s	5s	+0%
`poly_use_hint`	✅	5s	3s	+67%
`polyeta_unpack`	✅	5s	7s	-29%
`polyt1_unpack`	✅	5s	2s	+150%
`polyveck_pack_t0`	✅	5s	2s	+150%
`polyveck_unpack_t0`	✅	5s	4s	+25%
`polyvecl_chknorm`	✅	5s	6s	-17%
`polyz_unpack`	✅	5s	3s	+67%
`shake128_release`	✅	5s	3s	+67%
`sign_signature`	✅	5s	4s	+25%
`sign_signature_pre_hash_internal`	✅	5s	6s	-17%
`sign_verify_pre_hash_internal`	✅	5s	4s	+25%
`sys_check_capability`	✅	5s	4s	+25%
`decompose`	✅	4s	4s	+0%
`keccakf1600_xor_bytes (big endian)`	✅	4s	2s	+100%
`make_hint`	✅	4s	3s	+33%
`mld_ct_get_optblocker_u8`	✅	4s	2s	+100%
`mld_keccakf1600_extract_bytes`	✅	4s	2s	+100%
`mld_prepare_domain_separation_prefix`	✅	4s	5s	-20%
`ntt_native_x86_64`	✅	4s	4s	+0%
`pack_sig_z`	✅	4s	3s	+33%
`pack_sk`	✅	4s	4s	+0%
`poly_caddq_c`	✅	4s	4s	+0%
`poly_chknorm_native`	✅	4s	5s	-20%
`poly_sub`	✅	4s	2s	+100%
`poly_uniform_gamma1`	✅	4s	5s	-20%
`poly_uniform_gamma1_4x`	✅	4s	3s	+33%
`polyveck_pack_eta`	✅	4s	4s	+0%
`polyvecl_pointwise_acc_montgomery_native`	✅	4s	4s	+0%
`polyvecl_unpack_eta`	✅	4s	4s	+0%
`polyz_pack`	✅	4s	4s	+0%
`polyz_unpack_c`	✅	4s	4s	+0%
`polyz_unpack_native`	✅	4s	4s	+0%
`rej_eta_c`	✅	4s	3s	+33%
`shake128_absorb`	✅	4s	2s	+100%
`sign_keypair`	✅	4s	5s	-20%
`sign_open`	✅	4s	4s	+0%
`sign_signature_extmu`	✅	4s	3s	+33%
`sign_verify`	✅	4s	3s	+33%
`unpack_pk`	✅	4s	4s	+0%
`unpack_sk`	✅	4s	5s	-20%
`keccak_squeeze`	✅	3s	5s	-40%
`keccakf1600_extract_bytes (big endian)`	✅	3s	2s	+50%
`keccakf1600x4_xor_bytes`	✅	3s	2s	+50%
`mld_ct_abs_i32`	✅	3s	2s	+50%
`mld_ct_cmask_neg_i32`	✅	3s	1s	+200%
`mld_ct_cmask_nonzero_u32`	✅	3s	2s	+50%
`mld_value_barrier_u8`	✅	3s	2s	+50%
`montgomery_reduce`	✅	3s	3s	+0%
`pack_pk`	✅	3s	4s	-25%
`pack_sig_c_h`	✅	3s	4s	-25%
`poly_caddq`	✅	3s	4s	-25%
`poly_challenge`	✅	3s	5s	-40%
`poly_chknorm`	✅	3s	4s	-25%
`poly_decompose`	✅	3s	2s	+50%
`poly_invntt_tomont_native`	✅	3s	4s	-25%
`poly_ntt_native`	✅	3s	6s	-50%
`poly_pointwise_montgomery_native`	✅	3s	4s	-25%
`poly_power2round`	✅	3s	2s	+50%
`poly_reduce`	✅	3s	4s	-25%
`poly_uniform`	✅	3s	3s	+0%
`poly_use_hint_native`	✅	3s	3s	+0%
`polyeta_pack`	✅	3s	2s	+50%
`polyt0_pack`	✅	3s	6s	-50%
`polyveck_chknorm`	✅	3s	7s	-57%
`polyvecl_pack_eta`	✅	3s	3s	+0%
`polyvecl_pointwise_acc_montgomery`	✅	3s	4s	-25%
`polyvecl_uniform_gamma1`	✅	3s	5s	-40%
`polyvecl_uniform_gamma1_serial`	✅	3s	4s	-25%
`polyvecl_unpack_z`	✅	3s	2s	+50%
`polyw1_pack`	✅	3s	4s	-25%
`reduce32`	✅	3s	4s	-25%
`rej_eta_native`	✅	3s	6s	-50%
`shake128_init`	✅	3s	3s	+0%
`shake128x4_absorb_once`	✅	3s	3s	+0%
`shake256`	✅	3s	3s	+0%
`shake256_finalize`	✅	3s	3s	+0%
`shake256x4_absorb_once`	✅	3s	4s	-25%
`sign_verify_extmu`	✅	3s	2s	+50%
`sign_verify_pre_hash_shake256`	✅	3s	4s	-25%
`unpack_sig`	✅	3s	5s	-40%
`caddq`	✅	2s	3s	-33%
`fqscale`	✅	2s	2s	+0%
`keccak_finalize`	✅	2s	2s	+0%
`keccak_init`	✅	2s	2s	+0%
`keccakf1600x4_permute`	✅	2s	2s	+0%
`mld_ct_cmask_nonzero_u8`	✅	2s	2s	+0%
`mld_ct_get_optblocker_i64`	✅	2s	3s	-33%
`mld_h`	✅	2s	4s	-50%
`mld_value_barrier_i64`	✅	2s	1s	+100%
`poly_caddq_native`	✅	2s	4s	-50%
`poly_decompose_native`	✅	2s	4s	-50%
`poly_invntt_tomont`	✅	2s	2s	+0%
`poly_ntt`	✅	2s	1s	+100%
`poly_ntt_c`	✅	2s	4s	-50%
`poly_pointwise_montgomery`	✅	2s	2s	+0%
`poly_shiftl`	✅	2s	4s	-50%
`polyt1_pack`	✅	2s	4s	-50%
`polyveck_pack_w1`	✅	2s	2s	+0%
`polyveck_unpack_eta`	✅	2s	2s	+0%
`polyvecl_permute_bitrev_to_custom`	✅	2s	5s	-60%
`power2round`	✅	2s	1s	+100%
`rej_eta`	✅	2s	5s	-60%
`shake128_finalize`	✅	2s	2s	+0%
`shake128x4_squeezeblocks`	✅	2s	3s	-33%
`shake256_absorb`	✅	2s	3s	-33%
`shake256_init`	✅	2s	2s	+0%
`shake256_release`	✅	2s	2s	+0%
`shake256x4_squeezeblocks`	✅	2s	3s	-33%
`sign_signature_pre_hash_shake256`	✅	2s	4s	-50%
`use_hint`	✅	2s	3s	-33%
`keccakf1600_xor_bytes`	✅	1s	4s	-75%
`mld_ct_get_optblocker_u32`	✅	1s	3s	-67%
`mld_ct_sel_int32`	✅	1s	1s	+0%
`mld_value_barrier_u32`	✅	1s	2s	-50%
`shake128_squeeze`	✅	1s	2s	-50%
`shake256_squeeze`	✅	1s	2s	-50%

mkannwischer

Thanks @L-series. I checked that this matches the changes made in mlkem-native and verified that lint and format work as they should locally. LGTM.

Add linting for shell scripts in the scipts directory as well as any *.sh file accross the project using shellcheck. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>

Fix errors brought up by the linter. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>

resolved.

L-series force-pushed the shellcheck branch 2 times, most recently from 3b2e198 to ad1f9e0 Compare December 1, 2025 01:49

L-series marked this pull request as ready for review December 1, 2025 01:59

L-series requested a review from a team as a code owner December 1, 2025 01:59

hanno-becker reviewed Dec 1, 2025

View reviewed changes

Comment thread scripts/lint

L-series force-pushed the shellcheck branch 2 times, most recently from e61a5c5 to 8635352 Compare December 1, 2025 15:15

hanno-becker reviewed Dec 1, 2025

View reviewed changes

Comment thread scripts/format Outdated

hanno-becker previously requested changes Dec 1, 2025

View reviewed changes

L-series force-pushed the shellcheck branch from 8635352 to c4f6dc1 Compare December 1, 2025 19:33

L-series force-pushed the shellcheck branch 3 times, most recently from 054002b to 67a36aa Compare December 1, 2025 20:01

hanno-becker reviewed Dec 2, 2025

View reviewed changes

Comment thread scripts/format Outdated

hanno-becker reviewed Dec 2, 2025

View reviewed changes

Comment thread scripts/lint Outdated

mkannwischer changed the title ~~linting: add shelcheck for shell script lint~~ linting: add shellcheck for shell script lint Dec 3, 2025

L-series force-pushed the shellcheck branch 5 times, most recently from c2209ca to 7482a42 Compare December 15, 2025 03:27

L-series force-pushed the shellcheck branch 4 times, most recently from f2f74f3 to 9dd0fa7 Compare December 23, 2025 22:50

L-series requested a review from hanno-becker December 23, 2025 22:50

L-series force-pushed the shellcheck branch 3 times, most recently from 8c1b11e to f17ce9f Compare January 4, 2026 19:11

hanno-becker reviewed Jan 4, 2026

View reviewed changes

Comment thread scripts/format Outdated

L-series force-pushed the shellcheck branch 3 times, most recently from 397da23 to a252564 Compare January 8, 2026 14:53

L-series force-pushed the shellcheck branch 2 times, most recently from 1eb548e to e393bf9 Compare January 22, 2026 15:36

L-series force-pushed the shellcheck branch 2 times, most recently from 2d3a855 to 095c325 Compare January 24, 2026 04:29

mkannwischer approved these changes Jan 24, 2026

View reviewed changes

L-series added 2 commits January 24, 2026 16:59

linting: add shelcheck for shell script lint

16cd94d

Add linting for shell scripts in the scipts directory as well as any *.sh file accross the project using shellcheck. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>

linting: shell: fix shellcheck warnings

bb94c4a

Fix errors brought up by the linter. Signed-off-by: Andreas Hatziiliou <andreas.hatziiliou@savoirfairelinux.com>

mkannwischer force-pushed the shellcheck branch from 095c325 to bb94c4a Compare January 24, 2026 08:59

mkannwischer merged commit 3b15cc6 into main Jan 24, 2026
341 checks passed

mkannwischer deleted the shellcheck branch January 24, 2026 10:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linting: add shellcheck for shell script lint#756

linting: add shellcheck for shell script lint#756
mkannwischer merged 2 commits into
mainfrom
shellcheck

L-series commented Dec 1, 2025 •

edited by mkannwischer

Loading

Uh oh!

Uh oh!

Uh oh!

hanno-becker left a comment

Uh oh!

L-series commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanno-becker commented Jan 22, 2026

Uh oh!

L-series commented Jan 22, 2026

Uh oh!

oqs-bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

oqs-bot commented Jan 22, 2026 •

edited

Loading

Uh oh!

mkannwischer left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

L-series commented Dec 1, 2025 • edited by mkannwischer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanno-becker left a comment

Choose a reason for hiding this comment

Uh oh!

L-series commented Dec 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hanno-becker commented Jan 22, 2026

Uh oh!

L-series commented Jan 22, 2026

Uh oh!

oqs-bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-44)

Uh oh!

oqs-bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-87)

Uh oh!

oqs-bot commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CBMC Results (ML-DSA-65)

Uh oh!

mkannwischer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

L-series commented Dec 1, 2025 •

edited by mkannwischer

Loading

oqs-bot commented Jan 22, 2026 •

edited

Loading

oqs-bot commented Jan 22, 2026 •

edited

Loading

oqs-bot commented Jan 22, 2026 •

edited

Loading

mkannwischer left a comment •

edited

Loading