CBMC: Remove namespacing

[f15hr]

Resolves #824

Based on the changes made by pq-code-package/mlkem-native@cdc2269. Additionally, I added the configuration file like in pq-code-package/mlkem-native@cdc2269 to more closely resemble the current state of mlkem-native. I did not include the malloc changes.

[hanno-becker]

Thanks @f15hr, can you also incorporate the latest changes pq-code-package/mlkem-native#1471 ?

[f15hr]

Thanks @f15hr, can you also incorporate the latest changes pq-code-package/mlkem-native#1471 ?

Okay, I believe everything is sorted now. The test for SLOTHY failed because it was unable to secure an instance on aws. Everything else seems to work.

[hanno-becker]

Thanks @f15hr! There's at least one function remaining where the pattern is not yet used. Can you check please?

[oqs-bot]

CBMC Results (ML-DSA-44)

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	1901s	1953s	-2.7%
mld_attempt_signature_generation	✅	225s	224s	+0%
polyvecl_pointwise_acc_montgomery_c	✅	206s	207s	-0%
poly_pointwise_montgomery_c	✅	138s	139s	-1%
rej_uniform_native	✅	131s	130s	+1%
sign_verify_internal	✅	122s	152s	-20%
mld_ct_memcmp	✅	81s	82s	-1%
mld_invntt_layer	✅	76s	73s	+4%
keccak_squeezeblocks_x4	✅	47s	45s	+4%
mld_ntt_layer	✅	44s	45s	-2%
sign_signature_internal	✅	35s	38s	-8%
fqmul	✅	20s	20s	+0%
rej_uniform	✅	20s	22s	-9%
rej_uniform_c	✅	19s	20s	-5%
polyvec_matrix_expand	✅	17s	18s	-6%
poly_chknorm_c	✅	16s	18s	-11%
poly_uniform_4x	✅	16s	16s	+0%
poly_uniform_eta_4x	✅	16s	16s	+0%
polymat_permute_bitrev_to_custom	✅	15s	18s	-17%
polyt0_unpack	✅	14s	16s	-12%
keccakf1600x4_permute_native	✅	13s	13s	+0%
polyeta_unpack	✅	13s	9s	+44%
keccak_absorb_once_x4	✅	12s	12s	+0%
mld_compute_t0_t1_tr_from_sk_components	✅	12s	12s	+0%
mld_ntt_butterfly_block	✅	12s	13s	-8%
polyz_unpack_c	✅	12s	11s	+9%
mld_polyvecl_permute_bitrev_to_custom_native	✅	10s	9s	+11%
keccakf1600_permute_native	✅	9s	8s	+12%
poly_invntt_tomont_c	✅	9s	9s	+0%
polyvec_matrix_pointwise_montgomery	✅	9s	8s	+12%
keccakf1600_permute	✅	8s	9s	-11%
mld_sample_s1_s2	✅	7s	3s	+133%
polyveck_add	✅	7s	7s	+0%
polyveck_decompose	✅	7s	9s	-22%
polyveck_use_hint	✅	7s	3s	+133%
sign	✅	7s	8s	-12%
keccak_absorb	✅	6s	7s	-14%
polyt0_pack	✅	6s	4s	+50%
polyvec_matrix_expand_serial	✅	6s	7s	-14%
polyveck_invntt_tomont	✅	6s	4s	+50%
polyveck_ntt	✅	6s	5s	+20%
polyveck_power2round	✅	6s	6s	+0%
polyvecl_unpack_z	✅	6s	2s	+200%
sign_keypair	✅	6s	5s	+20%
sign_verify	✅	6s	6s	+0%
mld_compute_pack_z	✅	5s	7s	-29%
mld_ct_cmask_nonzero_u8	✅	5s	4s	+25%
ntt_native_x86_64	✅	5s	4s	+25%
pack_pk	✅	5s	2s	+150%
poly_add	✅	5s	15s	-67%
poly_caddq_native	✅	5s	6s	-17%
poly_chknorm	✅	5s	4s	+25%
poly_decompose_native	✅	5s	5s	+0%
poly_ntt_c	✅	5s	5s	+0%
poly_reduce	✅	5s	2s	+150%
poly_uniform_gamma1	✅	5s	4s	+25%
poly_use_hint	✅	5s	3s	+67%
polyveck_caddq	✅	5s	8s	-38%
polyveck_pointwise_poly_montgomery	✅	5s	4s	+25%
polyveck_shiftl	✅	5s	5s	+0%
polyvecl_chknorm	✅	5s	5s	+0%
polyz_unpack_native	✅	5s	4s	+25%
shake256_release	✅	5s	1s	+400%
sign_pk_from_sk	✅	5s	6s	-17%
sign_signature_pre_hash_internal	✅	5s	5s	+0%
sign_signature_pre_hash_shake256	✅	5s	3s	+67%
sign_verify_pre_hash_shake256	✅	5s	5s	+0%
unpack_sk	✅	5s	3s	+67%
keccak_finalize	✅	4s	2s	+100%
keccakf1600x4_permute	✅	4s	2s	+100%
mld_check_pct	✅	4s	7s	-43%
mld_ct_cmask_neg_i32	✅	4s	4s	+0%
mld_ct_get_optblocker_u32	✅	4s	1s	+300%
mld_value_barrier_u32	✅	4s	2s	+100%
mld_value_barrier_u8	✅	4s	1s	+300%
poly_decompose	✅	4s	2s	+100%
poly_decompose_c	✅	4s	2s	+100%
poly_invntt_tomont_native	✅	4s	3s	+33%
poly_ntt	✅	4s	3s	+33%
poly_uniform_eta	✅	4s	6s	-33%
poly_uniform_gamma1_4x	✅	4s	6s	-33%
poly_use_hint_c	✅	4s	4s	+0%
polyeta_pack	✅	4s	4s	+0%
polyt1_pack	✅	4s	3s	+33%
polyveck_make_hint	✅	4s	3s	+33%
polyveck_pack_t0	✅	4s	3s	+33%
polyveck_pack_w1	✅	4s	4s	+0%
polyveck_reduce	✅	4s	4s	+0%
polyveck_sub	✅	4s	5s	-20%
polyveck_unpack_eta	✅	4s	3s	+33%
polyveck_unpack_t0	✅	4s	2s	+100%
polyvecl_ntt	✅	4s	5s	-20%
polyvecl_permute_bitrev_to_custom	✅	4s	3s	+33%
polyvecl_pointwise_acc_montgomery	✅	4s	2s	+100%
polyvecl_pointwise_acc_montgomery_native	✅	4s	5s	-20%
power2round	✅	4s	5s	-20%
rej_eta_c	✅	4s	5s	-20%
rej_eta_native	✅	4s	4s	+0%
shake128x4_absorb_once	✅	4s	5s	-20%
sign_open	✅	4s	4s	+0%
sign_signature_extmu	✅	4s	5s	-20%
sign_verify_pre_hash_internal	✅	4s	4s	+0%
sys_check_capability	✅	4s	2s	+100%
unpack_hints	✅	4s	5s	-20%
caddq	✅	3s	3s	+0%
decompose	✅	3s	3s	+0%
fqscale	✅	3s	3s	+0%
keccak_init	✅	3s	3s	+0%
keccak_squeeze	✅	3s	6s	-50%
keccakf1600x4_extract_bytes	✅	3s	4s	-25%
make_hint	✅	3s	2s	+50%
mld_ct_get_optblocker_u8	✅	3s	4s	-25%
mld_ct_sel_int32	✅	3s	3s	+0%
mld_h	✅	3s	5s	-40%
mld_keccakf1600_extract_bytes	✅	3s	2s	+50%
mld_prepare_domain_separation_prefix	✅	3s	3s	+0%
mld_sample_s1_s2_serial	✅	3s	5s	-40%
montgomery_reduce	✅	3s	2s	+50%
pack_sk	✅	3s	4s	-25%
poly_caddq	✅	3s	3s	+0%
poly_caddq_c	✅	3s	3s	+0%
poly_challenge	✅	3s	5s	-40%
poly_invntt_tomont	✅	3s	4s	-25%
poly_make_hint	✅	3s	3s	+0%
poly_pointwise_montgomery	✅	3s	2s	+50%
poly_pointwise_montgomery_native	✅	3s	3s	+0%
poly_power2round	✅	3s	3s	+0%
poly_shiftl	✅	3s	5s	-40%
poly_sub	✅	3s	4s	-25%
poly_use_hint_native	✅	3s	4s	-25%
polyt1_unpack	✅	3s	3s	+0%
polyveck_pack_eta	✅	3s	4s	-25%
polyvecl_pack_eta	✅	3s	2s	+50%
polyvecl_unpack_eta	✅	3s	3s	+0%
polyw1_pack	✅	3s	3s	+0%
reduce32	✅	3s	3s	+0%
shake128_init	✅	3s	2s	+50%
shake128x4_squeezeblocks	✅	3s	3s	+0%
shake256_finalize	✅	3s	4s	-25%
shake256_init	✅	3s	2s	+50%
shake256x4_absorb_once	✅	3s	5s	-40%
sign_keypair_internal	✅	3s	5s	-40%
unpack_pk	✅	3s	2s	+50%
keccakf1600_extract_bytes (big endian)	✅	2s	2s	+0%
keccakf1600_xor_bytes	✅	2s	2s	+0%
keccakf1600_xor_bytes (big endian)	✅	2s	1s	+100%
mld_ct_abs_i32	✅	2s	1s	+100%
mld_ct_cmask_nonzero_u32	✅	2s	3s	-33%
mld_ct_get_optblocker_i64	✅	2s	2s	+0%
mld_value_barrier_i64	✅	2s	3s	-33%
pack_sig_c_h	✅	2s	3s	-33%
poly_chknorm_native	✅	2s	3s	-33%
poly_ntt_native	✅	2s	3s	-33%
poly_uniform	✅	2s	6s	-67%
polyveck_chknorm	✅	2s	4s	-50%
polyvecl_uniform_gamma1	✅	2s	2s	+0%
polyvecl_uniform_gamma1_serial	✅	2s	5s	-60%
polyz_pack	✅	2s	3s	-33%
polyz_unpack	✅	2s	5s	-60%
rej_eta	✅	2s	3s	-33%
shake128_absorb	✅	2s	1s	+100%
shake128_release	✅	2s	4s	-50%
shake128_squeeze	✅	2s	4s	-50%
shake256	✅	2s	2s	+0%
shake256_absorb	✅	2s	4s	-50%
shake256_squeeze	✅	2s	3s	-33%
shake256x4_squeezeblocks	✅	2s	2s	+0%
sign_signature	✅	2s	4s	-50%
sign_verify_extmu	✅	2s	4s	-50%
unpack_sig	✅	2s	3s	-33%
use_hint	✅	2s	2s	+0%
keccakf1600x4_xor_bytes	✅	1s	2s	-50%
pack_sig_z	✅	1s	3s	-67%
shake128_finalize	✅	1s	4s	-75%

[oqs-bot]

CBMC Results (ML-DSA-65)

⚠️ Attention Required

Proof	Status	Current	Previous	Change
mld_attempt_signature_generation	⚠️	395s	218s	+81%
mld_compute_t0_t1_tr_from_sk_components	⚠️	25s	16s	+56%

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	2325s	2314s	+0.5%
mld_attempt_signature_generation	⚠️	395s	218s	+81%
polyvecl_pointwise_acc_montgomery_c	✅	212s	237s	-11%
sign_verify_internal	✅	166s	238s	-30%
poly_pointwise_montgomery_c	✅	135s	144s	-6%
polyvec_matrix_expand	✅	132s	131s	+1%
rej_uniform_native	✅	125s	133s	-6%
mld_ct_memcmp	✅	78s	81s	-4%
polyvec_matrix_expand_serial	✅	65s	58s	+12%
mld_invntt_layer	✅	59s	61s	-3%
sign_signature_internal	✅	47s	48s	-2%
keccak_squeezeblocks_x4	✅	44s	45s	-2%
mld_ntt_layer	✅	43s	46s	-7%
mld_compute_t0_t1_tr_from_sk_components	⚠️	25s	16s	+56%
rej_uniform	✅	20s	22s	-9%
polyveck_decompose	✅	19s	16s	+19%
fqmul	✅	18s	20s	-10%
polymat_permute_bitrev_to_custom	✅	18s	19s	-5%
polyt0_unpack	✅	16s	14s	+14%
poly_uniform_eta_4x	✅	15s	17s	-12%
rej_uniform_c	✅	15s	17s	-12%
mld_ntt_butterfly_block	✅	14s	13s	+8%
poly_uniform_4x	✅	13s	15s	-13%
polyvec_matrix_pointwise_montgomery	✅	13s	14s	-7%
keccakf1600x4_permute_native	✅	12s	13s	-8%
polyveck_use_hint	✅	12s	6s	+100%
keccak_absorb_once_x4	✅	11s	12s	-8%
mld_check_pct	✅	11s	15s	-27%
poly_chknorm_c	✅	11s	13s	-15%
poly_decompose_c	✅	10s	11s	-9%
polyveck_invntt_tomont	✅	10s	9s	+11%
sign	✅	10s	12s	-17%
keccakf1600_permute_native	✅	9s	9s	+0%
polyveck_add	✅	9s	10s	-10%
polyveck_caddq	✅	9s	7s	+29%
sign_pk_from_sk	✅	9s	6s	+50%
keccakf1600_permute	✅	8s	8s	+0%
mld_polyvecl_permute_bitrev_to_custom_native	✅	8s	8s	+0%
poly_caddq_native	✅	8s	3s	+167%
poly_invntt_tomont_c	✅	8s	9s	-11%
polyveck_ntt	✅	8s	23s	-65%
polyveck_sub	✅	8s	11s	-27%
polyvecl_ntt	✅	8s	8s	+0%
mld_sample_s1_s2_serial	✅	7s	4s	+75%
poly_make_hint	✅	7s	3s	+133%
polyveck_power2round	✅	7s	9s	-22%
polyveck_shiftl	✅	7s	9s	-22%
polyvecl_pointwise_acc_montgomery_native	✅	7s	5s	+40%
sign_keypair_internal	✅	7s	7s	+0%
keccak_absorb	✅	6s	6s	+0%
mld_h	✅	6s	3s	+100%
polyt0_pack	✅	6s	4s	+50%
polyveck_pointwise_poly_montgomery	✅	6s	8s	-25%
polyveck_reduce	✅	6s	8s	-25%
polyvecl_chknorm	✅	6s	2s	+200%
polyz_unpack_c	✅	6s	3s	+100%
sign_signature	✅	6s	6s	+0%
sign_signature_pre_hash_internal	✅	6s	4s	+50%
keccakf1600_extract_bytes (big endian)	✅	5s	4s	+25%
keccakf1600_xor_bytes (big endian)	✅	5s	3s	+67%
make_hint	✅	5s	2s	+150%
mld_prepare_domain_separation_prefix	✅	5s	2s	+150%
mld_sample_s1_s2	✅	5s	7s	-29%
mld_value_barrier_u32	✅	5s	2s	+150%
pack_pk	✅	5s	2s	+150%
poly_uniform_gamma1	✅	5s	2s	+150%
poly_use_hint_c	✅	5s	5s	+0%
polyeta_unpack	✅	5s	7s	-29%
rej_eta_c	✅	5s	4s	+25%
shake256	✅	5s	3s	+67%
sign_open	✅	5s	3s	+67%
sign_verify_pre_hash_internal	✅	5s	5s	+0%
unpack_hints	✅	5s	6s	-17%
unpack_sig	✅	5s	3s	+67%
mld_ct_cmask_neg_i32	✅	4s	2s	+100%
ntt_native_x86_64	✅	4s	6s	-33%
pack_sig_c_h	✅	4s	3s	+33%
pack_sig_z	✅	4s	3s	+33%
poly_add	✅	4s	11s	-64%
poly_caddq_c	✅	4s	3s	+33%
poly_challenge	✅	4s	5s	-20%
poly_chknorm	✅	4s	6s	-33%
poly_ntt_c	✅	4s	5s	-20%
poly_ntt_native	✅	4s	3s	+33%
poly_pointwise_montgomery_native	✅	4s	4s	+0%
poly_uniform	✅	4s	5s	-20%
poly_uniform_gamma1_4x	✅	4s	7s	-43%
poly_use_hint_native	✅	4s	5s	-20%
polyeta_pack	✅	4s	2s	+100%
polyveck_make_hint	✅	4s	6s	-33%
polyveck_pack_w1	✅	4s	5s	-20%
polyvecl_permute_bitrev_to_custom	✅	4s	5s	-20%
polyvecl_unpack_eta	✅	4s	5s	-20%
polyw1_pack	✅	4s	5s	-20%
polyz_unpack	✅	4s	4s	+0%
rej_eta_native	✅	4s	7s	-43%
sign_keypair	✅	4s	4s	+0%
sign_signature_pre_hash_shake256	✅	4s	2s	+100%
sign_verify	✅	4s	6s	-33%
sign_verify_pre_hash_shake256	✅	4s	4s	+0%
unpack_sk	✅	4s	6s	-33%
fqscale	✅	3s	4s	-25%
keccak_squeeze	✅	3s	4s	-25%
keccakf1600_xor_bytes	✅	3s	1s	+200%
mld_compute_pack_z	✅	3s	9s	-67%
mld_ct_abs_i32	✅	3s	5s	-40%
mld_ct_get_optblocker_u8	✅	3s	1s	+200%
mld_value_barrier_i64	✅	3s	1s	+200%
montgomery_reduce	✅	3s	4s	-25%
pack_sk	✅	3s	4s	-25%
poly_chknorm_native	✅	3s	4s	-25%
poly_decompose	✅	3s	3s	+0%
poly_decompose_native	✅	3s	3s	+0%
poly_invntt_tomont	✅	3s	4s	-25%
poly_pointwise_montgomery	✅	3s	3s	+0%
poly_uniform_eta	✅	3s	4s	-25%
poly_use_hint	✅	3s	2s	+50%
polyveck_chknorm	✅	3s	5s	-40%
polyveck_unpack_eta	✅	3s	4s	-25%
polyveck_unpack_t0	✅	3s	4s	-25%
polyvecl_pack_eta	✅	3s	2s	+50%
polyvecl_unpack_z	✅	3s	3s	+0%
polyz_unpack_native	✅	3s	4s	-25%
power2round	✅	3s	4s	-25%
shake128_absorb	✅	3s	3s	+0%
shake128_finalize	✅	3s	2s	+50%
shake128_release	✅	3s	2s	+50%
shake128_squeeze	✅	3s	2s	+50%
shake128x4_absorb_once	✅	3s	2s	+50%
shake128x4_squeezeblocks	✅	3s	4s	-25%
shake256_absorb	✅	3s	4s	-25%
shake256_release	✅	3s	2s	+50%
shake256x4_squeezeblocks	✅	3s	5s	-40%
sign_verify_extmu	✅	3s	3s	+0%
sys_check_capability	✅	3s	3s	+0%
unpack_pk	✅	3s	3s	+0%
use_hint	✅	3s	3s	+0%
caddq	✅	2s	4s	-50%
keccak_finalize	✅	2s	2s	+0%
keccakf1600x4_extract_bytes	✅	2s	2s	+0%
keccakf1600x4_permute	✅	2s	2s	+0%
mld_ct_cmask_nonzero_u32	✅	2s	3s	-33%
mld_ct_get_optblocker_i64	✅	2s	2s	+0%
mld_ct_sel_int32	✅	2s	3s	-33%
mld_keccakf1600_extract_bytes	✅	2s	2s	+0%
poly_caddq	✅	2s	3s	-33%
poly_invntt_tomont_native	✅	2s	4s	-50%
poly_ntt	✅	2s	4s	-50%
poly_power2round	✅	2s	3s	-33%
poly_reduce	✅	2s	4s	-50%
poly_shiftl	✅	2s	3s	-33%
poly_sub	✅	2s	3s	-33%
polyt1_pack	✅	2s	2s	+0%
polyt1_unpack	✅	2s	3s	-33%
polyveck_pack_eta	✅	2s	2s	+0%
polyveck_pack_t0	✅	2s	5s	-60%
polyvecl_pointwise_acc_montgomery	✅	2s	3s	-33%
polyvecl_uniform_gamma1	✅	2s	4s	-50%
polyvecl_uniform_gamma1_serial	✅	2s	4s	-50%
polyz_pack	✅	2s	4s	-50%
reduce32	✅	2s	1s	+100%
rej_eta	✅	2s	3s	-33%
shake128_init	✅	2s	3s	-33%
shake256_finalize	✅	2s	3s	-33%
shake256_init	✅	2s	2s	+0%
shake256x4_absorb_once	✅	2s	2s	+0%
sign_signature_extmu	✅	2s	4s	-50%
decompose	✅	1s	3s	-67%
keccak_init	✅	1s	2s	-50%
keccakf1600x4_xor_bytes	✅	1s	3s	-67%
mld_ct_cmask_nonzero_u8	✅	1s	3s	-67%
mld_ct_get_optblocker_u32	✅	1s	4s	-75%
mld_value_barrier_u8	✅	1s	3s	-67%
shake256_squeeze	✅	1s	1s	+0%

[oqs-bot]

CBMC Results (ML-DSA-87)

Full Results (173 proofs)

Proof	Status	Current	Previous	Change
**TOTAL**	✅	2189s	2370s	-7.6%
mld_attempt_signature_generation	✅	201s	213s	-6%
polyvec_matrix_expand	✅	188s	135s	+39%
polyvecl_pointwise_acc_montgomery_c	✅	171s	172s	-1%
rej_uniform_native	✅	129s	125s	+3%
poly_pointwise_montgomery_c	✅	128s	125s	+2%
sign_verify_internal	✅	122s	373s	-67%
polyvec_matrix_expand_serial	✅	103s	118s	-13%
mld_ct_memcmp	✅	81s	80s	+1%
mld_invntt_layer	✅	61s	58s	+5%
sign_signature_internal	✅	60s	56s	+7%
keccak_squeezeblocks_x4	✅	44s	43s	+2%
mld_ntt_layer	✅	43s	41s	+5%
mld_compute_t0_t1_tr_from_sk_components	✅	25s	18s	+39%
polymat_permute_bitrev_to_custom	✅	23s	24s	-4%
rej_uniform	✅	21s	20s	+5%
fqmul	✅	20s	19s	+5%
poly_chknorm_c	✅	19s	17s	+12%
rej_uniform_c	✅	17s	18s	-6%
poly_uniform_4x	✅	16s	16s	+0%
poly_uniform_eta_4x	✅	15s	16s	-6%
polyeta_unpack	✅	15s	14s	+7%
polyveck_add	✅	15s	15s	+0%
polyveck_power2round	✅	15s	8s	+88%
polyt0_unpack	✅	14s	11s	+27%
keccakf1600x4_permute_native	✅	13s	12s	+8%
mld_ntt_butterfly_block	✅	13s	11s	+18%
polyvec_matrix_pointwise_montgomery	✅	13s	12s	+8%
keccak_absorb_once_x4	✅	12s	11s	+9%
polyveck_use_hint	✅	11s	7s	+57%
polyveck_caddq	✅	10s	7s	+43%
keccakf1600_permute_native	✅	9s	8s	+12%
polyveck_reduce	✅	9s	7s	+29%
sign	✅	9s	8s	+12%
keccakf1600_permute	✅	8s	8s	+0%
mld_polyvecl_permute_bitrev_to_custom_native	✅	8s	8s	+0%
poly_invntt_tomont_c	✅	8s	7s	+14%
unpack_sk	✅	8s	5s	+60%
keccak_absorb	✅	7s	6s	+17%
mld_check_pct	✅	7s	7s	+0%
mld_h	✅	7s	4s	+75%
mld_sample_s1_s2_serial	✅	7s	7s	+0%
poly_decompose_c	✅	7s	7s	+0%
polyveck_chknorm	✅	7s	6s	+17%
polyveck_decompose	✅	7s	8s	-12%
polyveck_ntt	✅	7s	9s	-22%
polyveck_shiftl	✅	7s	6s	+17%
polyvecl_ntt	✅	7s	7s	+0%
polyz_unpack_c	✅	7s	6s	+17%
rej_eta_c	✅	7s	4s	+75%
sign_pk_from_sk	✅	7s	10s	-30%
unpack_hints	✅	7s	8s	-12%
mld_sample_s1_s2	✅	6s	6s	+0%
poly_challenge	✅	6s	5s	+20%
polyveck_invntt_tomont	✅	6s	7s	-14%
polyveck_pointwise_poly_montgomery	✅	6s	8s	-25%
polyveck_sub	✅	6s	9s	-33%
polyvecl_unpack_z	✅	6s	3s	+100%
sign_keypair_internal	✅	6s	6s	+0%
sign_signature_pre_hash_shake256	✅	6s	4s	+50%
sign_verify_pre_hash_shake256	✅	6s	3s	+100%
decompose	✅	5s	2s	+150%
mld_ct_cmask_nonzero_u8	✅	5s	3s	+67%
mld_ct_sel_int32	✅	5s	1s	+400%
pack_pk	✅	5s	3s	+67%
poly_chknorm	✅	5s	3s	+67%
poly_uniform_eta	✅	5s	3s	+67%
poly_uniform_gamma1_4x	✅	5s	2s	+150%
polyveck_make_hint	✅	5s	7s	-29%
polyveck_pack_t0	✅	5s	6s	-17%
sign_signature	✅	5s	4s	+25%
sign_verify	✅	5s	5s	+0%
unpack_pk	✅	5s	5s	+0%
unpack_sig	✅	5s	3s	+67%
keccakf1600x4_xor_bytes	✅	4s	2s	+100%
mld_compute_pack_z	✅	4s	7s	-43%
mld_value_barrier_i64	✅	4s	1s	+300%
pack_sig_z	✅	4s	3s	+33%
poly_add	✅	4s	14s	-71%
poly_decompose	✅	4s	3s	+33%
poly_decompose_native	✅	4s	4s	+0%
poly_ntt	✅	4s	3s	+33%
poly_ntt_c	✅	4s	6s	-33%
poly_uniform	✅	4s	4s	+0%
poly_uniform_gamma1	✅	4s	4s	+0%
poly_use_hint	✅	4s	2s	+100%
polyt1_pack	✅	4s	2s	+100%
polyveck_pack_eta	✅	4s	3s	+33%
polyveck_pack_w1	✅	4s	4s	+0%
polyveck_unpack_t0	✅	4s	2s	+100%
polyvecl_permute_bitrev_to_custom	✅	4s	2s	+100%
polyvecl_pointwise_acc_montgomery	✅	4s	4s	+0%
polyvecl_uniform_gamma1	✅	4s	5s	-20%
polyvecl_uniform_gamma1_serial	✅	4s	2s	+100%
polyvecl_unpack_eta	✅	4s	2s	+100%
polyw1_pack	✅	4s	3s	+33%
polyz_unpack_native	✅	4s	3s	+33%
reduce32	✅	4s	3s	+33%
shake128x4_absorb_once	✅	4s	3s	+33%
shake256_init	✅	4s	3s	+33%
shake256_squeeze	✅	4s	4s	+0%
sign_open	✅	4s	4s	+0%
sign_signature_extmu	✅	4s	4s	+0%
sign_verify_extmu	✅	4s	6s	-33%
sys_check_capability	✅	4s	4s	+0%
fqscale	✅	3s	2s	+50%
keccak_squeeze	✅	3s	2s	+50%
keccakf1600_xor_bytes	✅	3s	4s	-25%
keccakf1600_xor_bytes (big endian)	✅	3s	1s	+200%
keccakf1600x4_extract_bytes	✅	3s	2s	+50%
mld_ct_cmask_nonzero_u32	✅	3s	5s	-40%
mld_ct_get_optblocker_i64	✅	3s	2s	+50%
mld_keccakf1600_extract_bytes	✅	3s	2s	+50%
pack_sig_c_h	✅	3s	4s	-25%
poly_caddq	✅	3s	4s	-25%
poly_caddq_c	✅	3s	3s	+0%
poly_chknorm_native	✅	3s	3s	+0%
poly_invntt_tomont	✅	3s	4s	-25%
poly_pointwise_montgomery	✅	3s	3s	+0%
poly_pointwise_montgomery_native	✅	3s	5s	-40%
poly_power2round	✅	3s	2s	+50%
poly_reduce	✅	3s	3s	+0%
poly_shiftl	✅	3s	4s	-25%
poly_sub	✅	3s	5s	-40%
polyeta_pack	✅	3s	3s	+0%
polyt0_pack	✅	3s	4s	-25%
polyt1_unpack	✅	3s	2s	+50%
polyveck_unpack_eta	✅	3s	6s	-50%
polyvecl_chknorm	✅	3s	7s	-57%
polyz_pack	✅	3s	3s	+0%
polyz_unpack	✅	3s	2s	+50%
power2round	✅	3s	4s	-25%
rej_eta	✅	3s	2s	+50%
rej_eta_native	✅	3s	5s	-40%
shake128_absorb	✅	3s	3s	+0%
shake128x4_squeezeblocks	✅	3s	4s	-25%
shake256_absorb	✅	3s	1s	+200%
sign_keypair	✅	3s	5s	-40%
sign_signature_pre_hash_internal	✅	3s	4s	-25%
sign_verify_pre_hash_internal	✅	3s	4s	-25%
caddq	✅	2s	2s	+0%
keccak_finalize	✅	2s	3s	-33%
keccak_init	✅	2s	1s	+100%
keccakf1600_extract_bytes (big endian)	✅	2s	3s	-33%
keccakf1600x4_permute	✅	2s	3s	-33%
make_hint	✅	2s	3s	-33%
mld_ct_abs_i32	✅	2s	3s	-33%
mld_ct_cmask_neg_i32	✅	2s	2s	+0%
mld_ct_get_optblocker_u32	✅	2s	2s	+0%
mld_ct_get_optblocker_u8	✅	2s	2s	+0%
mld_prepare_domain_separation_prefix	✅	2s	5s	-60%
mld_value_barrier_u8	✅	2s	2s	+0%
montgomery_reduce	✅	2s	4s	-50%
ntt_native_x86_64	✅	2s	4s	-50%
pack_sk	✅	2s	3s	-33%
poly_caddq_native	✅	2s	5s	-60%
poly_invntt_tomont_native	✅	2s	3s	-33%
poly_make_hint	✅	2s	2s	+0%
poly_ntt_native	✅	2s	2s	+0%
poly_use_hint_c	✅	2s	4s	-50%
poly_use_hint_native	✅	2s	5s	-60%
polyvecl_pack_eta	✅	2s	4s	-50%
polyvecl_pointwise_acc_montgomery_native	✅	2s	4s	-50%
shake128_init	✅	2s	1s	+100%
shake128_release	✅	2s	2s	+0%
shake128_squeeze	✅	2s	2s	+0%
shake256	✅	2s	2s	+0%
shake256_finalize	✅	2s	5s	-60%
shake256_release	✅	2s	2s	+0%
shake256x4_absorb_once	✅	2s	2s	+0%
shake256x4_squeezeblocks	✅	2s	3s	-33%
use_hint	✅	2s	4s	-50%
mld_value_barrier_u32	✅	1s	1s	+0%
shake128_finalize	✅	1s	1s	+0%

[f15hr]

Thanks @f15hr! There's at least one function remaining where the pattern is not yet used. Can you check please?

Ah, fixed now.

[mkannwischer]

A couple functions are not yet following the format.

[mkannwischer]

Can you try if you get the poly_add and sign_verify_internal performance back to it's original by increasing CBMC_OBJECT_BITS to 10, 11, or 12?

[f15hr]

Sorry for the delay on this PR, I double checked and I believe there are no more issues, and it should be up to date with main.

[mkannwischer]

Thanks @f15hr! LGTM.

resolved