x86_64/AArch64: Add .size directive to all assembly functions#956
Merged
Conversation
Add size information to function symbols. size information is added through a MLD_ASM_FN_SIZE macro (mapping to .size for elf-targets and nothing otherwise) which gets added automatically by autogen. The makes the assembly functions show up with their correct size in the elf instead of always having a zero size, making it easier to see how much space each function takes up. Co-authored-by: Anders Sonmark <Anders.Sonmark@axis.com> Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
mkannwischer
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Feb 7, 2026
Add size information to function symbols. Size information is added through a MLD_ASM_FN_SIZE macro (mapping to .size for elf-targets and nothing otherwise) which gets added automatically by autogen. The makes the assembly functions show up with their correct size in the elf instead of always having a zero size, making it easier to see how much space each function takes up. - Port of pq-code-package/mldsa-native#956 Co-authored-by: Anders Sonmark <Anders.Sonmark@axis.com> Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
Contributor
CBMC Results (ML-DSA-44)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (174 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (174 proofs)
|
hanno-becker
approved these changes
Feb 7, 2026
Contributor
hanno-becker
left a comment
There was a problem hiding this comment.
Thank you, very clean to integrate it into simpasm
mkannwischer
added a commit
to pq-code-package/mlkem-native
that referenced
this pull request
Feb 7, 2026
Add size information to function symbols. Size information is added through a MLD_ASM_FN_SIZE macro (mapping to .size for elf-targets and nothing otherwise) which gets added automatically by autogen. The makes the assembly functions show up with their correct size in the elf instead of always having a zero size, making it easier to see how much space each function takes up. - Port of pq-code-package/mldsa-native#956 Co-authored-by: Anders Sonmark <Anders.Sonmark@axis.com> Signed-off-by: Matthias J. Kannwischer <matthias@kannwischer.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add size information to function symbols.
size information is added through a MLD_ASM_FN_SIZE macro (mapping to .size for elf-targets and nothing otherwise) which gets added automatically by autogen. The makes the assembly
functions show up with their correct size in the elf instead of always having a zero size, making it easier to see how much space each function takes up.