Skip to content

Correct assertion in polyveck_add()#988

Merged
hanno-becker merged 1 commit into
mainfrom
polyveck_add_assert
Mar 3, 2026
Merged

Correct assertion in polyveck_add()#988
hanno-becker merged 1 commit into
mainfrom
polyveck_add_assert

Conversation

@rod-chapman
Copy link
Copy Markdown
Contributor

Correct assertion in polyveck_add()

It was previously asserting the correct range on values in u->vec in the range 0 .. <MLDSA_L, but this should be 0 .. <MLDSA_K.

Since MLDSA_L <= MLDSA_K for all parameter sets, this passes proof and runtime checking, but is weak.

The loop-invariant and post-condition of this function are correct, so proof of calling units is not affected.

It was previously asserting the correct range on values in
u->vec in the range 0 .. <MLDSA_L, but this should be
0 .. <MLDSA_K.

Since MLDSA_L <= MLDSA_K for all parameter sets, this passes
proof and runtime checking, but is weak.

The loop-invariant and post-condition of this function
are correct, so proof of calling units is not affected.

Signed-off-by: Rod Chapman <rodchap@amazon.com>
@rod-chapman rod-chapman self-assigned this Mar 3, 2026
@rod-chapman rod-chapman requested a review from a team as a code owner March 3, 2026 12:29
@rod-chapman rod-chapman requested a review from hanno-becker March 3, 2026 12:35
@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 3, 2026

CBMC Results (ML-DSA-65)

Full Results (175 proofs)
Proof Status Current Previous Change
**TOTAL** 2379s 2290s +3.9%
polyvecl_pointwise_acc_montgomery_c 250s 225s +11%
mld_attempt_signature_generation 208s 192s +8%
sign_verify_internal 179s 176s +2%
poly_pointwise_montgomery_c 151s 135s +12%
polyvec_matrix_expand 147s 146s +1%
rej_uniform_native 147s 139s +6%
mld_invntt_layer 125s 120s +4%
mld_ct_memcmp 87s 79s +10%
polyvec_matrix_expand_serial 68s 64s +6%
sign_signature_internal 52s 53s -2%
mld_ntt_layer 45s 44s +2%
keccak_squeezeblocks_x4 44s 42s +5%
mld_compute_t0_t1_tr_from_sk_components 28s 26s +8%
poly_chknorm_c 22s 20s +10%
polymat_permute_bitrev_to_custom 21s 18s +17%
rej_uniform 20s 20s +0%
fqmul 19s 19s +0%
rej_uniform_c 19s 16s +19%
poly_uniform_eta_4x 18s 16s +12%
poly_uniform_4x 17s 14s +21%
polyveck_decompose 17s 17s +0%
polyt0_unpack 16s 13s +23%
polyvec_matrix_pointwise_montgomery 15s 16s -6%
mld_ntt_butterfly_block 14s 11s +27%
mld_polyvecl_permute_bitrev_to_custom_native 14s 13s +8%
polyveck_use_hint 14s 13s +8%
keccakf1600x4_permute_native 12s 14s -14%
polyveck_ntt 12s 6s +100%
keccak_absorb_once_x4 11s 9s +22%
mld_check_pct 11s 12s -8%
poly_invntt_tomont_c 11s 9s +22%
sign 11s 11s +0%
polyveck_add 10s 10s +0%
polyvecl_ntt 10s 9s +11%
polyveck_caddq 9s 10s -10%
polyveck_power2round 9s 7s +29%
keccak_absorb 8s 7s +14%
mld_sample_s1_s2 8s 5s +60%
poly_decompose_c 8s 9s -11%
poly_use_hint_c 8s 4s +100%
polyveck_invntt_tomont 8s 8s +0%
polyveck_reduce 8s 9s -11%
polyveck_sub 8s 8s +0%
polyvecl_uniform_gamma1_serial 8s 4s +100%
sign_pk_from_sk 8s 9s -11%
keccakf1600_permute 7s 8s -12%
poly_invntt_tomont 7s 2s +250%
polyeta_unpack 7s 5s +40%
polyveck_shiftl 7s 7s +0%
keccakf1600_permute_native 6s 7s -14%
mld_compute_pack_z 6s 6s +0%
poly_reduce 6s 3s +100%
poly_use_hint 6s 5s +20%
polyveck_chknorm 6s 3s +100%
polyveck_pointwise_poly_montgomery 6s 7s -14%
polyz_unpack_c 6s 5s +20%
reduce32 6s 4s +50%
sign_keypair_internal 6s 6s +0%
unpack_hints 6s 5s +20%
unpack_pk 6s 4s +50%
decompose 5s 4s +25%
fqscale 5s 3s +67%
make_hint 5s 2s +150%
poly_caddq_c 5s 7s -29%
poly_caddq_native 5s 3s +67%
poly_make_hint 5s 5s +0%
polyt1_unpack 5s 4s +25%
polyveck_unpack_t0 5s 6s -17%
sign_signature 5s 4s +25%
sign_signature_pre_hash_shake256 5s 5s +0%
sign_verify_pre_hash_internal 5s 4s +25%
unpack_sk 5s 4s +25%
intt_native_x86_64 4s 3s +33%
keccakf1600x4_xor_bytes 4s 4s +0%
mld_ct_get_optblocker_u32 4s 2s +100%
mld_prepare_domain_separation_prefix 4s 3s +33%
mld_sample_s1_s2_serial 4s 5s -20%
pack_sk 4s 3s +33%
poly_caddq 4s 2s +100%
poly_challenge 4s 4s +0%
poly_chknorm_native 4s 4s +0%
poly_ntt_c 4s 1s +300%
poly_sub 4s 3s +33%
poly_uniform 4s 3s +33%
poly_uniform_eta 4s 5s -20%
poly_uniform_gamma1_4x 4s 4s +0%
polyt0_pack 4s 5s -20%
polyveck_make_hint 4s 5s -20%
polyveck_unpack_eta 4s 2s +100%
polyvecl_pack_eta 4s 6s -33%
polyz_unpack 4s 2s +100%
rej_eta 4s 2s +100%
rej_eta_c 4s 3s +33%
rej_eta_native 4s 5s -20%
shake128_finalize 4s 6s -33%
shake128x4_squeezeblocks 4s 1s +300%
shake256_release 4s 3s +33%
sign_keypair 4s 4s +0%
sign_open 4s 4s +0%
sign_signature_extmu 4s 3s +33%
sign_verify 4s 3s +33%
use_hint 4s 3s +33%
caddq 3s 4s -25%
keccak_init 3s 3s +0%
keccakf1600_extract_bytes (big endian) 3s 2s +50%
keccakf1600_xor_bytes 3s 2s +50%
mld_ct_cmask_nonzero_u32 3s 3s +0%
mld_ct_get_optblocker_u8 3s 3s +0%
mld_value_barrier_i64 3s 4s -25%
pack_sig_c_h 3s 3s +0%
pack_sig_z 3s 3s +0%
poly_add 3s 5s -40%
poly_caddq_native_aarch64 3s 2s +50%
poly_chknorm 3s 4s -25%
poly_decompose_native 3s 2s +50%
poly_invntt_tomont_native 3s 3s +0%
poly_uniform_gamma1 3s 6s -50%
poly_use_hint_native 3s 4s -25%
polyeta_pack 3s 3s +0%
polyveck_pack_eta 3s 4s -25%
polyveck_pack_t0 3s 4s -25%
polyveck_pack_w1 3s 4s -25%
polyvecl_pointwise_acc_montgomery 3s 4s -25%
polyvecl_pointwise_acc_montgomery_native 3s 6s -50%
polyvecl_uniform_gamma1 3s 6s -50%
polyvecl_unpack_eta 3s 5s -40%
polyw1_pack 3s 5s -40%
shake128_absorb 3s 2s +50%
shake128_release 3s 3s +0%
shake128_squeeze 3s 1s +200%
shake128x4_absorb_once 3s 3s +0%
shake256_finalize 3s 3s +0%
sign_signature_pre_hash_internal 3s 3s +0%
sign_verify_extmu 3s 5s -40%
sign_verify_pre_hash_shake256 3s 2s +50%
unpack_sig 3s 4s -25%
keccak_squeeze 2s 5s -60%
keccakf1600_xor_bytes (big endian) 2s 3s -33%
mld_ct_abs_i32 2s 4s -50%
mld_ct_cmask_neg_i32 2s 2s +0%
mld_ct_cmask_nonzero_u8 2s 4s -50%
mld_ct_get_optblocker_i64 2s 3s -33%
mld_ct_sel_int32 2s 4s -50%
mld_h 2s 3s -33%
mld_keccakf1600_extract_bytes 2s 2s +0%
mld_value_barrier_u32 2s 3s -33%
mld_value_barrier_u8 2s 5s -60%
pack_pk 2s 2s +0%
poly_decompose 2s 6s -67%
poly_ntt 2s 5s -60%
poly_ntt_native 2s 3s -33%
poly_pointwise_montgomery 2s 3s -33%
poly_pointwise_montgomery_native 2s 3s -33%
poly_power2round 2s 4s -50%
polyt1_pack 2s 3s -33%
polyvecl_chknorm 2s 4s -50%
polyvecl_permute_bitrev_to_custom 2s 2s +0%
polyvecl_unpack_z 2s 3s -33%
polyz_unpack_native 2s 3s -33%
power2round 2s 5s -60%
shake256_absorb 2s 3s -33%
shake256_init 2s 2s +0%
shake256_squeeze 2s 5s -60%
shake256x4_absorb_once 2s 3s -33%
sys_check_capability 2s 4s -50%
keccak_finalize 1s 3s -67%
keccakf1600x4_extract_bytes 1s 4s -75%
keccakf1600x4_permute 1s 4s -75%
montgomery_reduce 1s 1s +0%
ntt_native_x86_64 1s 4s -75%
poly_shiftl 1s 4s -75%
polyz_pack 1s 3s -67%
shake128_init 1s 3s -67%
shake256 1s 2s -50%
shake256x4_squeezeblocks 1s 3s -67%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 3, 2026

CBMC Results (ML-DSA-44)

Full Results (175 proofs)
Proof Status Current Previous Change
**TOTAL** 2168s 2029s +6.9%
sign_verify_internal 263s 244s +8%
mld_attempt_signature_generation 234s 217s +8%
polyvecl_pointwise_acc_montgomery_c 222s 199s +12%
poly_pointwise_montgomery_c 151s 132s +14%
rej_uniform_native 150s 136s +10%
mld_ct_memcmp 93s 79s +18%
mld_invntt_layer 53s 53s +0%
mld_ntt_layer 46s 45s +2%
keccak_squeezeblocks_x4 44s 41s +7%
sign_signature_internal 44s 45s -2%
poly_invntt_tomont_c 40s 37s +8%
fqmul 21s 19s +11%
rej_uniform 21s 20s +5%
rej_uniform_c 20s 17s +18%
poly_uniform_4x 18s 15s +20%
poly_uniform_eta_4x 17s 15s +13%
polymat_permute_bitrev_to_custom 17s 17s +0%
polyvec_matrix_expand 17s 14s +21%
polyt0_unpack 15s 19s -21%
keccakf1600x4_permute_native 14s 12s +17%
mld_polyvecl_permute_bitrev_to_custom_native 14s 15s -7%
polyeta_unpack 14s 13s +8%
keccak_absorb_once_x4 13s 12s +8%
mld_compute_t0_t1_tr_from_sk_components 13s 15s -13%
mld_ntt_butterfly_block 13s 12s +8%
poly_chknorm_c 13s 12s +8%
poly_caddq_c 11s 9s +22%
polyz_unpack_c 11s 12s -8%
poly_use_hint_c 8s 5s +60%
polyvec_matrix_pointwise_montgomery 8s 8s +0%
polyvecl_chknorm 8s 6s +33%
sign_keypair_internal 8s 5s +60%
keccak_absorb 7s 6s +17%
keccakf1600_permute_native 7s 8s -12%
mld_check_pct 7s 9s -22%
pack_sig_c_h 7s 3s +133%
polyvec_matrix_expand_serial 7s 7s +0%
polyveck_add 7s 10s -30%
polyveck_decompose 7s 6s +17%
polyveck_invntt_tomont 7s 4s +75%
polyw1_pack 7s 3s +133%
sign_pk_from_sk 7s 7s +0%
unpack_hints 7s 3s +133%
unpack_sk 7s 5s +40%
keccakf1600_permute 6s 8s -25%
mld_compute_pack_z 6s 5s +20%
poly_chknorm_native 6s 6s +0%
polyveck_ntt 6s 6s +0%
polyveck_reduce 6s 6s +0%
polyvecl_ntt 6s 6s +0%
sign 6s 7s -14%
sign_keypair 6s 3s +100%
sign_open 6s 3s +100%
sign_signature_pre_hash_internal 6s 6s +0%
sign_verify_extmu 6s 5s +20%
intt_native_x86_64 5s 3s +67%
pack_sig_z 5s 3s +67%
poly_add 5s 6s -17%
poly_decompose_c 5s 6s -17%
poly_ntt_c 5s 3s +67%
poly_uniform_eta 5s 4s +25%
polyveck_caddq 5s 6s -17%
polyveck_make_hint 5s 4s +25%
polyveck_pack_t0 5s 4s +25%
polyveck_pointwise_poly_montgomery 5s 6s -17%
polyveck_shiftl 5s 3s +67%
polyveck_sub 5s 4s +25%
polyveck_use_hint 5s 5s +0%
polyvecl_uniform_gamma1_serial 5s 2s +150%
rej_eta_c 5s 5s +0%
sign_verify 5s 5s +0%
sign_verify_pre_hash_shake256 5s 2s +150%
fqscale 4s 3s +33%
keccak_init 4s 4s +0%
keccak_squeeze 4s 3s +33%
keccakf1600_xor_bytes (big endian) 4s 2s +100%
mld_ct_get_optblocker_i64 4s 3s +33%
mld_prepare_domain_separation_prefix 4s 3s +33%
mld_sample_s1_s2 4s 4s +0%
mld_value_barrier_u8 4s 3s +33%
poly_decompose 4s 2s +100%
poly_ntt 4s 1s +300%
poly_power2round 4s 5s -20%
poly_reduce 4s 4s +0%
poly_shiftl 4s 4s +0%
poly_uniform_gamma1 4s 4s +0%
polyeta_pack 4s 3s +33%
polyveck_power2round 4s 6s -33%
polyvecl_pack_eta 4s 4s +0%
polyvecl_pointwise_acc_montgomery_native 4s 3s +33%
polyvecl_unpack_eta 4s 4s +0%
rej_eta_native 4s 9s -56%
shake256 4s 3s +33%
shake256_absorb 4s 3s +33%
shake256x4_absorb_once 4s 2s +100%
sign_signature 4s 3s +33%
sign_signature_extmu 4s 3s +33%
sign_signature_pre_hash_shake256 4s 4s +0%
sign_verify_pre_hash_internal 4s 3s +33%
sys_check_capability 4s 1s +300%
use_hint 4s 3s +33%
caddq 3s 4s -25%
decompose 3s 4s -25%
keccakf1600_xor_bytes 3s 3s +0%
keccakf1600x4_extract_bytes 3s 3s +0%
mld_ct_cmask_nonzero_u32 3s 1s +200%
mld_ct_cmask_nonzero_u8 3s 3s +0%
mld_ct_get_optblocker_u8 3s 1s +200%
mld_h 3s 3s +0%
mld_keccakf1600_extract_bytes 3s 2s +50%
mld_sample_s1_s2_serial 3s 5s -40%
mld_value_barrier_i64 3s 2s +50%
ntt_native_x86_64 3s 3s +0%
pack_pk 3s 5s -40%
poly_chknorm 3s 3s +0%
poly_decompose_native 3s 4s -25%
poly_invntt_tomont 3s 4s -25%
poly_make_hint 3s 4s -25%
poly_pointwise_montgomery_native 3s 4s -25%
poly_sub 3s 3s +0%
poly_uniform 3s 2s +50%
poly_uniform_gamma1_4x 3s 6s -50%
poly_use_hint 3s 4s -25%
poly_use_hint_native 3s 4s -25%
polyveck_chknorm 3s 4s -25%
polyveck_unpack_t0 3s 1s +200%
polyvecl_pointwise_acc_montgomery 3s 4s -25%
polyvecl_uniform_gamma1 3s 3s +0%
polyvecl_unpack_z 3s 4s -25%
polyz_unpack_native 3s 3s +0%
rej_eta 3s 2s +50%
shake128_finalize 3s 5s -40%
shake128_init 3s 2s +50%
shake128_release 3s 4s -25%
shake256_finalize 3s 3s +0%
shake256_release 3s 3s +0%
shake256_squeeze 3s 3s +0%
unpack_pk 3s 3s +0%
unpack_sig 3s 4s -25%
keccak_finalize 2s 2s +0%
keccakf1600x4_permute 2s 1s +100%
keccakf1600x4_xor_bytes 2s 5s -60%
make_hint 2s 2s +0%
mld_ct_abs_i32 2s 3s -33%
mld_ct_cmask_neg_i32 2s 3s -33%
mld_ct_get_optblocker_u32 2s 3s -33%
mld_ct_sel_int32 2s 1s +100%
mld_value_barrier_u32 2s 2s +0%
montgomery_reduce 2s 4s -50%
pack_sk 2s 3s -33%
poly_caddq 2s 2s +0%
poly_caddq_native 2s 3s -33%
poly_caddq_native_aarch64 2s 4s -50%
poly_challenge 2s 4s -50%
poly_invntt_tomont_native 2s 2s +0%
poly_ntt_native 2s 4s -50%
poly_pointwise_montgomery 2s 2s +0%
polyt0_pack 2s 5s -60%
polyt1_pack 2s 2s +0%
polyt1_unpack 2s 2s +0%
polyveck_pack_eta 2s 2s +0%
polyveck_pack_w1 2s 2s +0%
polyveck_unpack_eta 2s 2s +0%
polyvecl_permute_bitrev_to_custom 2s 1s +100%
polyz_pack 2s 5s -60%
polyz_unpack 2s 4s -50%
power2round 2s 4s -50%
shake128_absorb 2s 3s -33%
shake128x4_absorb_once 2s 2s +0%
shake128x4_squeezeblocks 2s 2s +0%
shake256_init 2s 3s -33%
shake256x4_squeezeblocks 2s 2s +0%
keccakf1600_extract_bytes (big endian) 1s 6s -83%
reduce32 1s 2s -50%
shake128_squeeze 1s 3s -67%

@oqs-bot
Copy link
Copy Markdown
Contributor

oqs-bot commented Mar 3, 2026

CBMC Results (ML-DSA-87)

Full Results (175 proofs)
Proof Status Current Previous Change
**TOTAL** 2530s 2492s +1.5%
sign_verify_internal 370s 361s +2%
mld_attempt_signature_generation 238s 233s +2%
polyvecl_pointwise_acc_montgomery_c 184s 169s +9%
polyvec_matrix_expand 158s 155s +2%
rej_uniform_native 149s 138s +8%
poly_pointwise_montgomery_c 138s 136s +1%
mld_invntt_layer 121s 119s +2%
polyvec_matrix_expand_serial 109s 107s +2%
mld_ct_memcmp 80s 81s -1%
sign_signature_internal 48s 53s -9%
mld_ntt_layer 46s 44s +5%
keccak_squeezeblocks_x4 41s 42s -2%
mld_compute_t0_t1_tr_from_sk_components 24s 25s -4%
polymat_permute_bitrev_to_custom 24s 26s -8%
rej_uniform_c 20s 16s +25%
fqmul 19s 20s -5%
rej_uniform 19s 20s -5%
poly_chknorm_c 18s 17s +6%
poly_uniform_4x 16s 14s +14%
poly_uniform_eta_4x 16s 15s +7%
polyt0_unpack 15s 15s +0%
mld_ntt_butterfly_block 14s 12s +17%
polyeta_unpack 13s 12s +8%
polyvec_matrix_pointwise_montgomery 13s 14s -7%
polyveck_power2round 13s 14s -7%
keccakf1600x4_permute_native 11s 15s -27%
keccak_absorb_once_x4 10s 10s +0%
mld_check_pct 10s 6s +67%
poly_invntt_tomont_c 10s 9s +11%
polyveck_reduce 10s 9s +11%
keccakf1600_permute 9s 7s +29%
poly_caddq_c 9s 7s +29%
poly_decompose_c 9s 10s -10%
polyveck_caddq 9s 10s -10%
polyveck_ntt 9s 7s +29%
polyveck_pointwise_poly_montgomery 9s 7s +29%
polyveck_use_hint 9s 11s -18%
sign 9s 8s +12%
sign_pk_from_sk 9s 8s +12%
sign_signature_pre_hash_shake256 9s 4s +125%
keccakf1600_permute_native 8s 8s +0%
mld_polyvecl_permute_bitrev_to_custom_native 8s 7s +14%
mld_sample_s1_s2 8s 9s -11%
polyveck_invntt_tomont 8s 9s -11%
polyvecl_ntt 8s 9s -11%
keccak_absorb 7s 6s +17%
polyveck_shiftl 7s 7s +0%
polyveck_sub 7s 7s +0%
polyvecl_chknorm 7s 4s +75%
mld_compute_pack_z 6s 6s +0%
mld_h 6s 4s +50%
mld_sample_s1_s2_serial 6s 6s +0%
polyveck_add 6s 16s -62%
polyveck_chknorm 6s 11s -45%
polyveck_decompose 6s 7s -14%
polyvecl_uniform_gamma1_serial 6s 3s +100%
polyvecl_unpack_eta 6s 5s +20%
sign_keypair_internal 6s 4s +50%
sign_signature_pre_hash_internal 6s 4s +50%
keccakf1600x4_permute 5s 3s +67%
mld_ct_cmask_nonzero_u8 5s 3s +67%
mld_ct_sel_int32 5s 3s +67%
poly_add 5s 2s +150%
poly_caddq_native 5s 2s +150%
poly_use_hint 5s 3s +67%
polyveck_unpack_t0 5s 3s +67%
polyvecl_pack_eta 5s 6s -17%
polyz_unpack_c 5s 4s +25%
sign_open 5s 3s +67%
sign_signature 5s 3s +67%
sign_signature_extmu 5s 3s +67%
keccakf1600x4_extract_bytes 4s 2s +100%
mld_ct_cmask_nonzero_u32 4s 2s +100%
mld_ct_get_optblocker_u8 4s 3s +33%
mld_value_barrier_u8 4s 2s +100%
montgomery_reduce 4s 6s -33%
ntt_native_x86_64 4s 6s -33%
pack_pk 4s 3s +33%
poly_caddq_native_aarch64 4s 2s +100%
poly_challenge 4s 5s -20%
poly_invntt_tomont_native 4s 4s +0%
poly_ntt 4s 2s +100%
poly_pointwise_montgomery_native 4s 3s +33%
poly_power2round 4s 2s +100%
poly_uniform 4s 5s -20%
poly_uniform_eta 4s 3s +33%
poly_uniform_gamma1 4s 2s +100%
poly_use_hint_c 4s 4s +0%
polyeta_pack 4s 3s +33%
polyt1_unpack 4s 3s +33%
polyveck_make_hint 4s 7s -43%
polyveck_unpack_eta 4s 5s -20%
polyvecl_uniform_gamma1 4s 3s +33%
polyvecl_unpack_z 4s 3s +33%
polyz_pack 4s 4s +0%
rej_eta_native 4s 4s +0%
shake128x4_squeezeblocks 4s 4s +0%
shake256x4_absorb_once 4s 1s +300%
unpack_hints 4s 5s -20%
unpack_sig 4s 2s +100%
unpack_sk 4s 4s +0%
caddq 3s 2s +50%
keccak_init 3s 3s +0%
keccakf1600_xor_bytes (big endian) 3s 4s -25%
keccakf1600x4_xor_bytes 3s 4s -25%
mld_ct_cmask_neg_i32 3s 2s +50%
mld_ct_get_optblocker_u32 3s 3s +0%
mld_prepare_domain_separation_prefix 3s 5s -40%
mld_value_barrier_i64 3s 2s +50%
pack_sig_c_h 3s 3s +0%
pack_sig_z 3s 2s +50%
pack_sk 3s 3s +0%
poly_chknorm 3s 4s -25%
poly_decompose_native 3s 4s -25%
poly_invntt_tomont 3s 2s +50%
poly_make_hint 3s 3s +0%
poly_ntt_c 3s 3s +0%
poly_reduce 3s 3s +0%
poly_shiftl 3s 2s +50%
poly_uniform_gamma1_4x 3s 5s -40%
polyt0_pack 3s 4s -25%
polyt1_pack 3s 3s +0%
polyveck_pack_eta 3s 5s -40%
polyveck_pack_t0 3s 4s -25%
polyveck_pack_w1 3s 2s +50%
polyvecl_permute_bitrev_to_custom 3s 2s +50%
polyvecl_pointwise_acc_montgomery_native 3s 4s -25%
rej_eta 3s 3s +0%
rej_eta_c 3s 3s +0%
shake128_absorb 3s 2s +50%
shake128_init 3s 3s +0%
shake256_absorb 3s 3s +0%
shake256_finalize 3s 4s -25%
sign_keypair 3s 2s +50%
sign_verify_extmu 3s 4s -25%
sign_verify_pre_hash_shake256 3s 4s -25%
sys_check_capability 3s 3s +0%
decompose 2s 5s -60%
intt_native_x86_64 2s 5s -60%
keccak_finalize 2s 3s -33%
keccakf1600_extract_bytes (big endian) 2s 4s -50%
make_hint 2s 3s -33%
mld_ct_abs_i32 2s 2s +0%
mld_ct_get_optblocker_i64 2s 3s -33%
mld_keccakf1600_extract_bytes 2s 2s +0%
poly_caddq 2s 2s +0%
poly_chknorm_native 2s 4s -50%
poly_decompose 2s 2s +0%
poly_ntt_native 2s 2s +0%
poly_pointwise_montgomery 2s 3s -33%
poly_sub 2s 3s -33%
poly_use_hint_native 2s 4s -50%
polyvecl_pointwise_acc_montgomery 2s 3s -33%
polyw1_pack 2s 5s -60%
polyz_unpack 2s 3s -33%
polyz_unpack_native 2s 2s +0%
power2round 2s 4s -50%
shake128_finalize 2s 2s +0%
shake128x4_absorb_once 2s 4s -50%
shake256_init 2s 2s +0%
shake256_squeeze 2s 3s -33%
shake256x4_squeezeblocks 2s 2s +0%
sign_verify 2s 6s -67%
sign_verify_pre_hash_internal 2s 3s -33%
unpack_pk 2s 5s -60%
use_hint 2s 3s -33%
fqscale 1s 3s -67%
keccak_squeeze 1s 3s -67%
keccakf1600_xor_bytes 1s 1s +0%
mld_value_barrier_u32 1s 2s -50%
reduce32 1s 2s -50%
shake128_release 1s 4s -75%
shake128_squeeze 1s 2s -50%
shake256 1s 2s -50%
shake256_release 1s 5s -80%

Copy link
Copy Markdown
Contributor

@hanno-becker hanno-becker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the fix. This was not flagged because a) It weaker than the correct version (since MLDSA_K >= MLDSA_L), hence correct; b) the assertion is not useful for the proof, but a vehicle to identify violations in debug builds.

@hanno-becker hanno-becker merged commit 08e63cc into main Mar 3, 2026
735 of 736 checks passed
@hanno-becker hanno-becker deleted the polyveck_add_assert branch March 3, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants