Add optional html_content property to error mapping
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* For cases where we need to render rich error markup (such as server- rendered errors), this method provides us with a (mostly) safe way of doing so by utilizing `DOMParser` * See: https://developer.mozilla.org/en-US/docs/Web/API/DOMParser/parseFromString
* The `html_content` key in an error map can be used to render rich markup for an error message instead of the plaintext `message` * If present, `message` is ignored. * Under the hood, `applyErrorMappingToForm` calls `errorMessageListItemWithHTML` for an error entry if `html_content` evaluates to a truthy value
tcannonfodder
deleted the
thomas/pract-140-add-optional-html_content-property-to-error-mapping
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
errorMessageListItemWithHTMLto parse an HTML string for renderingrendered errors), this method provides us with a (mostly) safe way of
doing so by utilizing
DOMParserAdd support for
html_contentin error mappinghtml_contentkey in an error map can be used to render richmarkup for an error message instead of the plaintext
messagemessageis ignored.applyErrorMappingToFormcallserrorMessageListItemWithHTMLfor an error entry ifhtml_contentevaluates to a truthy value