bracketmatch: fix position on wrapped lines#38
Merged
jgmdev merged 1 commit intopragtical:masterfrom Apr 2, 2026
Merged
Conversation
Member
|
Tested too and looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect position of characters and decorations in the bracketmatch plugin when lines are wrapped by something like the linewrapping plugin:
bracketmatch_fix2.mp4
The problem was that the plugin was trying to compute the screen position of the decorations and characters on its own, with no awareness of what the linewrapping plugin was doing. Now it uses DocView:get_line_screen_position instead, which accurately places the decorations where they're supposed to go.
I made sure it works with all the different plugin settings as well (frame, underline, block, etc).