Depend on python3-dnf, not dnf#1
Merged
praiskup merged 1 commit intopraiskup:masterfrom Jul 19, 2023
Merged
Conversation
praiskup
approved these changes
Jul 19, 2023
Owner
|
Thank you! |
Closed
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DNF5 is replacing DNF in Fedora 39+, so packages should no longer depend on the
dnfpackage.Ideally, this plugin would be updated for DNF5, but in the meantime, it should depend on
python3-dnfrather thandnf.dnf5andpython3-dnfcan be installed simultaneously and thus not break upgrading to Fedora 39, butdnf5anddnfconflict.dnfonly provides the/usr/bin/dnfbinary whereaspython3-dnfprovides all of DNF's actual functionality, so it should be safe to swap out the dependency, unlessdnf-plugin-diffactually depends on/usr/bin/dnffor some reason.