Fix for search function not working if "$hide_Cols=true" on non-Windo…#267
Merged
prasathmani merged 1 commit intoprasathmani:masterfrom Dec 20, 2019
Merged
Fix for search function not working if "$hide_Cols=true" on non-Windo…#267prasathmani merged 1 commit intoprasathmani:masterfrom
prasathmani merged 1 commit intoprasathmani:masterfrom
Conversation
…ws systems Setting $hide_Cols=true while having FM_IS_WIN=false will lead to a "Type error" when setting up the dataTable. The desired page is generated, but the Search function does not work, as the dataTable is broken. With this fix the dataTable is written accordingly, with either FM_IS_WIN or $hide_Cols set or unset.
prasathmani
approved these changes
Dec 20, 2019
joglomedia
pushed a commit
to joglomedia/tinyfilemanager
that referenced
this pull request
Dec 25, 2019
ner00
pushed a commit
to ner00/tinyfilemanager
that referenced
this pull request
May 7, 2023
…ws systems (prasathmani#267) Setting $hide_Cols=true while having FM_IS_WIN=false will lead to a "Type error" when setting up the dataTable. The desired page is generated, but the Search function does not work, as the dataTable is broken. With this fix the dataTable is written accordingly, with either FM_IS_WIN or $hide_Cols set or unset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ws systems
Setting $hide_Cols=true while having FM_IS_WIN=false will lead to a "Type error" when setting up the dataTable. The desired page is generated, but the Search function does not work, as the dataTable is broken.
With this fix the dataTable is written accordingly, with either FM_IS_WIN or $hide_Cols set or unset.