Support MD preview. Allow editing lua files. Use the latest ACE editor.#324
Closed
lchen198 wants to merge 1 commit intoprasathmani:masterfrom
Closed
Support MD preview. Allow editing lua files. Use the latest ACE editor.#324lchen198 wants to merge 1 commit intoprasathmani:masterfrom
lchen198 wants to merge 1 commit intoprasathmani:masterfrom
Conversation
imranzahid01
suggested changes
Apr 11, 2020
imranzahid01
left a comment
imranzahid01
left a comment
There was a problem hiding this comment.
The merge will cause a Javascript error, make the changes as suggested in the comments
| echo '<pre class="x-mdhere">'; | ||
| echo $content; | ||
| echo "</pre>"; | ||
| echo "<script>show_md();</script>"; |
There was a problem hiding this comment.
This will throw a Javascript error that show_md() doesn't exists. The reason is that this method hasn't been defined yet. It is defined in the footer
| } | ||
| markdown_els[i].innerHTML = converter.makeHtml(text); | ||
| } | ||
| } |
There was a problem hiding this comment.
Call this method in the // Dom Ready Event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have much experience with PHP and web development in general. Feel free to make changes on what I have.
http://dynalon.github.io/mdwiki/#!index.md
Screenshot:
https://ibb.co/TKD57vF