Added more status codes. Included some PEP8 formatting changes as wel… #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l. I also moved code into functions to better encapsulate functionality. Also moved if/elif/else to a dictionary to be more concise and readable.
|
Hello @molex! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on May 11, 2018 at 03:23 Hours UTC |
Owner
prateekiiest
left a comment
prateekiiest
left a comment
There was a problem hiding this comment.
Pretty cool implementation, opposed to the previous one.
LGTM 👍
Owner
|
Can you resolve those PEP8 issues. Then it will be good to go. |
Contributor
Author
|
New commit with requested changes. |
prateekiiest
approved these changes
May 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution. Please provide the details requested below.
ISSSUE #110
Please provide a link to the issue this pull request addresses.
SHORT DESCRIPTION
Added more status codes. Included some PEP8 formatting changes as well. I also moved code into functions to better encapsulate functionality. Also moved if/elif/else to a dictionary to be more concise and readable. Michael Brown 5/10/2018 10:06 PM
TESTING
Try any website and see the results. I tried http://www.google.com to ensure a good result, then I tried some randome addresses as well as some I knew would not work and saw the different results that matched what was expected..