Conversation
bboe
force-pushed
the
more_cleanup
branch
2 times, most recently
from
be44d06 to
52ba906
Compare
LilSpazJoekp
approved these changes
Feb 12, 2025
Member
LilSpazJoekp
left a comment
LilSpazJoekp
left a comment
There was a problem hiding this comment.
Few things but otherwise it looks good to me!
autofixed via: ruff check --fix --unsafe-fixes ruff format
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's too many changes here to try to do them atomically.I split up the auto-changes into their own commit. I've updated CHANGES.rst for changes which are publicly breaking, and we're not going to go through a deprecation period for these.