check_yaml hook has YAML file parsing issues

[bibermann]

The check_yaml hook has parsing issues when parsing a list containing an unquoted string with a colon, e.g.

key: [val:ue]

Can be fixed by configuring ruamel-yaml such that it's using its pure Python implementation instead of libyaml, like explained here: https://stackoverflow.com/a/62160118/704821

Affected code:

pre-commit-hooks/pre_commit_hooks/check_yaml.py

Line 11 in 6306a48

yaml = ruamel.yaml.YAML(typ='safe')

Fix:

- yaml = ruamel.yaml.YAML(typ='safe')
+ yaml = ruamel.yaml.YAML(typ='safe', pure=True)

This may lead to slower parsing though.

[asottile]

next time search for duplicates

[tankorsmash]

#918 is this the original?

[bibermann]

next time search for duplicates

I'm sorry that I did not expect closed duplicates. You probably mean #827 or #918.

I understand that fixing upstream bugs is not our responsibility.
But what is our responsibility, is to provide the features we promise to provide.

we're just a wrapper, report it to the parser [comment in #918]

Technically we may be the wrapper of some library, but that's an implementation detail. For the users, we are a pre-commit hook that promises to check YAML files. And they neither care about the politics of why something is not working, nor do they care about how the implementation is done at all. The users care about the functionality itself.

The work-around provided by @hut8 (#828) restores the functionality.

this is the (unacceptable) slow loader [comment in #828]

If this is too slow (for whom, actually?*), we can search for a better solution later (or wait until upstream is fixed).
But the highest priority now should be to give value to the users.

*) In the README I cannot find where we promise to be fast. Anyways, as the hooks only run when there are changes, the speed is negligible IMHO, or at least secondary.

[asottile]

feel free to fork, your decisions are not mine and I am not here to debate on something that's already been decided because you failed to spend a tiny bit of effort and search the issue tracker first