Fix test error "fatal: empty ident name (for <(null)>) not allowed"#154
Merged
asottile merged 1 commit intopre-commit:masterfrom Dec 2, 2016
Merged
Fix test error "fatal: empty ident name (for <(null)>) not allowed"#154asottile merged 1 commit intopre-commit:masterfrom
asottile merged 1 commit intopre-commit:masterfrom
Conversation
Member
|
This is already handled here: Lines 11 to 13 in 77a7bba (also you've got tabs) |
Contributor
Author
|
@asottile It's not handled when running the test from tox locally though I'll fix the tabs in a rebase :/ Edit: fixed |
This occurs when there is no global setting for git config options user.name and user.email
An example of the error shown below:
E pre_commit.util.CalledProcessError: Command: ('/usr/bin/git', 'commit', '-m', 'init', '--allow-empty')
E Return code: 128
E Expected return code: 0
E Output: (none)
E Errors:
E
E *** Please tell me who you are.
E
E Run
E
E git config --global user.email "you@example.com"
E git config --global user.name "Your Name"
E
E to set your account's default identity.
E Omit --global to set the identity only in this repository.
E
E fatal: empty ident name (for <(null)>) not allowed
Member
|
Thanks for the PR! |
Member
|
I imagine pre-commit/pre-commit could benefit from the same change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This occurs when there is no global setting for git config options user.name and user.email
An example of the error shown below: