Skip to content

Fix NoneTypeError when requirements file is empty #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asottile merged 1 commit into from
Jun 24, 2017
Merged

Fix NoneTypeError when requirements file is empty #205

asottile merged 1 commit into from
Jun 24, 2017
+13 −8

Conversation

@dan98765
Copy link

@dan98765 dan98765 commented Jun 24, 2017

Fixes #167

asottile
asottile reviewed Jun 24, 2017
View reviewed changes
pre_commit_hooks/requirements_txt_fixer.py

def fix_requirements(f):
requirements = []
before = []
Copy link
Member

@asottile asottile Jun 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could even do tuple(f) (since tuples are smaller, faster, and best of all immutable!)

@asottile
Copy link
Member

asottile commented Jun 24, 2017

Thanks for fixing this!

@asottile asottile merged commit d419bef into pre-commit:master Jun 24, 2017
@dan98765 dan98765 deleted the fix_requirements_txt_fixer_on_empty_requirements_files branch June 25, 2017 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dan98765 @asottile