Skip to content

Add nbqa to list of hooks #999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asottile merged 1 commit into from
Nov 25, 2024
Merged

Add nbqa to list of hooks #999

asottile merged 1 commit into from
Nov 25, 2024

Conversation

@MarcoGorelli
Copy link
Contributor

@MarcoGorelli MarcoGorelli commented Nov 20, 2024 •
edited
Loading

I think this fulfills the criteria:

  • ✅ the tool must already be fairly popular (>500 stars):
    • it has over 1100 stars, and >300k monthly downloads on PyPI stats
  • ✅ the tool must use a managed language (no system / script / docker hooks):
    • yup, it has types_or: [jupyter, markdown]
  • ✅ the tool must operate on files
    • yup

asottile
asottile approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile enabled auto-merge November 25, 2024 23:18
@asottile asottile merged commit 0b60971 into pre-commit:main Nov 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarcoGorelli @asottile