pre-commit and pylint installed as dev dependencies with poetry. Is this the right approach?

[maephisto666]

Hello,

I would like to know if what I'm doing is good enough or if there is a better approach.

This is my setup:

• very simple python application
• poetry to manage dependencies
• pre-commit installed as a --dev dependency by poetry
• pylint installed as a --dev dependency by poetry
• everything is working as expected (i.e. when I commit, pre-commit runs pylint and pylint does not complain about missing imports, because it is correctly executed in the virtualenv set up by poetry)

These are my hooks

repos:
  - repo: https://github.com/ambv/black
    rev: 21.9b0
    hooks:
    - id: black
      language_version: python3.9
  - repo: local
    hooks:
      - id: pylint
        name: pylint
        entry: poetry run pylint
        language: system
        types: [python]

Is it a good approach to install pre-commit, pylint, etc. as dev dependencies? Or shall I install pre-commit globally (via brew for example)?
Is there a better way to make sure pylint (through pre-commit) is executed with the required dependencies for my application?

[asottile]

seems fine -- note that you're probably fork-bombing pylint since you've got the default parallelism and pylint does its own parallelism

note also that your contributors will need to have poetry available globally which is not ideal

also you're using a twice-deprecated black clone url

[maephisto666]

Thanks @asottile for the answer.

1. I will fix the black repo
2. I thought having poetry as a global installation was a good assumption. What would be an alternative to this?
3. Can you point me to the right direction to understand the parallelism issue I could encounter? I'm expecting only one instance of pre-commit is running, thus executing black and the poetry run pylint once, so I can't see the parallelism issue...

[asottile]

I mean, I don't have poetry globally installed so I wouldn't expect everyone to have it -- that said if you're using unmanaged language: system hooks you're escaping the supported path of pre-commit managing the tools (pylint of course is tricky here because it does dynamic analysis and doesn't fit well in the normal model of things). as for the parallelism issue: https://pre-commit.com/#hooks-require_serial

[maephisto666]

Thanks Anthony. I will look into the - language: system - require_serial topics. Thank you very much for the help.

…

On Wed, 3 Nov 2021, 8:37 pm Anthony Sottile, ***@***.***> wrote: I mean, I don't have poetry globally installed so I wouldn't expect *everyone* to have it -- that said if you're using unmanaged language: system hooks you're escaping the supported path of pre-commit managing the tools (pylint of course is tricky here because it does *dynamic analysis* and doesn't fit well in the normal model of things). as for the parallelism issue: https://pre-commit.com/#hooks-require_serial — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB7PNWKYBMB4CNUSPYCSP6TUKGMOZANCNFSM5HJNM5JQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.