Skip to content

switch from python_hooks_repo to inline bash in autoupdate fixture #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-rsha wants to merge 1 commit into
base: main
Choose a base branch
from
+32 −5
Open

switch from python_hooks_repo to inline bash in autoupdate fixture #2824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 32 additions & 5 deletions tests/commands/autoupdate_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,40 @@


@pytest.fixture
def up_to_date(tempdir_factory):
yield make_repo(tempdir_factory, 'python_hooks_repo')
def up_to_date(tmp_path):
path = str(tmp_path)
cmd_output('git', 'init', path)
manifest = '''\
- id: foo
name: Foo
entry: foo.sh
language: script
Comment on lines +35 to +36
Copy link
Member

@asottile asottile Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can probably be even simpler with language: system and entry: true or something of the sort

files: ''
'''
tmp_path.joinpath('foo.sh').write_text('#!/usr/bin/env bash\necho "Hi!"')
tmp_path.joinpath(C.MANIFEST_FILE).write_text(manifest)

cmd_output('git', 'add', '.', cwd=path)
git_commit(msg='make_repo', cwd=path)
yield path


@pytest.fixture
def out_of_date(tempdir_factory):
path = make_repo(tempdir_factory, 'python_hooks_repo')
def out_of_date(tmp_path):
path = str(tmp_path)
cmd_output('git', 'init', path)
manifest = '''\
- id: foo
name: Foo
entry: foo.sh
language: script
files: ''
'''
tmp_path.joinpath('foo.sh').write_text('#!/usr/bin/env bash\necho "Hi!"')
tmp_path.joinpath(C.MANIFEST_FILE).write_text(manifest)

cmd_output('git', 'add', '.', cwd=path)
git_commit(msg='make_repo', cwd=path)
original_rev = git.head_rev(path)

git_commit(cwd=path)
Expand Down Expand Up @@ -420,7 +447,7 @@ def test_autoupdate_latest_no_config(out_of_date, in_tmpdir, store):
assert out_of_date.original_rev in f.read()


def test_hook_disppearing_repo_raises(hook_disappearing, store):
def test_hook_disappearing_repo_raises(hook_disappearing, store):
config = make_config_from_repo(
hook_disappearing.path,
rev=hook_disappearing.original_rev,
Expand Down